Skip to content

chore: remove creation of extra toml file in recursion inputs flow #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ledwards2225 merged 2 commits into from
Sep 23, 2024
Merged

chore: remove creation of extra toml file in recursion inputs flow #8700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871f458
remove creation of extra toml file
ledwards2225 Sep 23, 2024
2d91219
Merge branch 'master' into lde/remove_extra_toml
ledwards2225 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions barretenberg/cpp/src/barretenberg/bb/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,13 +1209,6 @@ void write_recursion_inputs_honk(const std::string& bytecodePath,
// Write all components to the TOML file
std::string toml_path = outputPath + "/Prover.toml";
write_file(toml_path, { toml_content.begin(), toml_content.end() });

// Write to additional dir for noir-sync purposes
std::string part_to_remove = "/noir-repo/test_programs/execution_success";
size_t pos = toml_path.find(part_to_remove);
std::string toml_path_2 = toml_path; // define path here
toml_path_2.erase(pos, part_to_remove.length());
write_file(toml_path_2, { toml_content.begin(), toml_content.end() });
}

/**
Expand Down
5 changes: 2 additions & 3 deletions barretenberg/cpp/src/barretenberg/dsl/acir_format/proof_surgeon.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class ProofSurgeon {

public:
/**
* @brief Write a toml file containing the inputs to a noir verify_proof call
* @brief Constrcut a string containing the inputs to a noir verify_proof call (to be written to a .toml)
*
* @param proof A complete bberg style proof (i.e. contains the public inputs)
* @param verification_key
Expand All @@ -40,13 +40,12 @@ class ProofSurgeon {
acir_format::ProofSurgeon::cut_public_inputs_from_proof(proof, num_public_inputs_to_extract);

// Construct json-style output for each component
// FF key_hash{ 0 }; // not used for Honk
std::string proof_json = to_json(proof);
std::string pub_inputs_json = to_json(public_inputs);
std::string vk_json = to_json(vkey_fields);

// Format with labels for noir recursion input
std::string toml_content = "key_hash = " + format("\"", FF(0), "\"") + "\n";
std::string toml_content = "key_hash = " + format("\"", FF(0), "\"") + "\n"; // not used by honk
toml_content += "proof = " + proof_json + "\n";
toml_content += "public_inputs = " + pub_inputs_json + "\n";
toml_content += "verification_key = " + vk_json + "\n";
Expand Down