[DO NOT MERGE] feat: contract entrypoint dispatch function #8726
Closed
asterite wants to merge 15 commits into
Closed
[DO NOT MERGE] feat: contract entrypoint dispatch function #8726asterite wants to merge 15 commits into
asterite wants to merge 15 commits into
Conversation
asterite
commented
Sep 24, 2024
asterite
commented
Sep 24, 2024
fcarreiro
reviewed
Sep 25, 2024
fcarreiro
reviewed
Sep 25, 2024
…re are no public functions
fcarreiro
reviewed
Sep 26, 2024
|
|
||
| /// A trait for types that can be deserialized from a calldata field array | ||
| #[derive_via(derive_from_calldata)] | ||
| pub trait FromCalldata<let N: u32> { |
Contributor
There was a problem hiding this comment.
I wonder if you can't use a Reader instead of having to define all these: https://github.com/AztecProtocol/aztec-packages/blob/master/noir-projects/noir-protocol-circuits/crates/types/src/utils/reader.nr
Contributor
There was a problem hiding this comment.
BTW when compiling all contracts I'm getting tons of "missing FromCalldata implementation" errors. IDK if it's feasible to reimplement all those.
error: No matching impl found for `EmbeddedCurvePoint: FromCalldata<_>`
┌─ contracts/token_contract/src/main.nr:14:3
│
14 │ #[aztec]
│ ----- No impl for `EmbeddedCurvePoint: FromCalldata<_>`
│
error: No matching impl found for `str<31>: FromCalldata<_>`
┌─ contracts/token_contract/src/main.nr:14:3
│
14 │ #[aztec]
│ ----- No impl for `str<31>: FromCalldata<_>`
│
error: Type annotation needed
┌─ contracts/auth_contract/src/main.nr:7:3
│
7 │ #[aztec]
│ ----- Could not determine type of generic argument
│
= Call stack:
1. contracts/auth_contract/src/main.nr:7:3
...
Contributor
Author
There was a problem hiding this comment.
Oh, I was just trying things on the avm test contract. I'll check all contracts and add the missing trait impls.
Contributor
|
I'll start building on this because we are blocked and need to make progress. Could you try to fix the stack overflow? |
Contributor
Author
|
Closed in favor of #8821 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.