chore: Test sticky comment on the public functions report#8755
Closed
vezenovm wants to merge 15 commits into
Closed
chore: Test sticky comment on the public functions report#8755vezenovm wants to merge 15 commits into
vezenovm wants to merge 15 commits into
Conversation
Contributor
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
… mv/test-public-func-report
TomAFrench
pushed a commit
that referenced
this pull request
Sep 25, 2024
Re-use https://github.com/noir-lang/noir-gates-diff for computing bytecode sizes of all public functions. I made a new script `noir-projects/noir-contracts/publicFunctionsSizeReport.js`. It runs through all the artifacts in the `target` directory of `noir-contracts` and collects all public functions. We then compare a report of bytecode sizes based upon the package name of `{contract_name}::{public_function_name}`. To see an example of the sticky comment after a public function change you can look at #8755.
Contributor
Author
|
Closing as this PR was simply for displaying what happens when public function bytecode sizes change after #8755. |
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Re-use https://github.com/noir-lang/noir-gates-diff for computing bytecode sizes of all public functions. I made a new script `noir-projects/noir-contracts/publicFunctionsSizeReport.js`. It runs through all the artifacts in the `target` directory of `noir-contracts` and collects all public functions. We then compare a report of bytecode sizes based upon the package name of `{contract_name}::{public_function_name}`. To see an example of the sticky comment after a public function change you can look at #8755.
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Re-use https://github.com/noir-lang/noir-gates-diff for computing bytecode sizes of all public functions. I made a new script `noir-projects/noir-contracts/publicFunctionsSizeReport.js`. It runs through all the artifacts in the `target` directory of `noir-contracts` and collects all public functions. We then compare a report of bytecode sizes based upon the package name of `{contract_name}::{public_function_name}`. To see an example of the sticky comment after a public function change you can look at #8755.
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Re-use https://github.com/noir-lang/noir-gates-diff for computing bytecode sizes of all public functions. I made a new script `noir-projects/noir-contracts/publicFunctionsSizeReport.js`. It runs through all the artifacts in the `target` directory of `noir-contracts` and collects all public functions. We then compare a report of bytecode sizes based upon the package name of `{contract_name}::{public_function_name}`. To see an example of the sticky comment after a public function change you can look at #8755.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display results of #8750 when we have changes in public function size.