[DO NOT MERGE] feat!: dispatch transition (first pass) by fcarreiro · Pull Request #8824 · AztecProtocol/aztec-packages

fcarreiro · 2024-09-26T13:51:45Z

Please read contributing guidelines and remove this line.

fcarreiro · 2024-09-26T13:51:57Z

[DO NOT MERGE] feat!: dispatch transition (first pass) #8824 👈
feat(aztec-nr/public): dispatch function #8821
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

github-actions · 2024-09-27T14:42:22Z

Changes to public function bytecode sizes

Generated at commit: 8e746cc2a4247edafad791ce6fb0df7bf77f7d4e, compared to commit: dda528a2f1ca1a52ce08f6175b594f6567fc370e

🧾 Summary (100% most significant diffs)

Program	Bytecode size in bytes (+/-)	%
AvmTest::pedersen_commit	+1,115 ❌	+318.57%
AvmTest::nested_call_to_add_with_gas	+656 ❌	+180.72%
AvmTest::nested_static_call_to_add	+628 ❌	+167.91%
AvmTest::nested_call_to_add	+628 ❌	+167.91%
AuthWitTest::consume_public	+586 ❌	+139.19%
StaticParent::public_get_value_from_child	+447 ❌	+124.51%
Parent::pub_entry_point_twice	+673 ❌	+124.17%
Parent::pub_entry_point	+433 ❌	+117.66%
StaticParent::public_call	+433 ❌	+117.66%
AvmTest::nested_static_call_to_set_storage	+368 ❌	+114.64%
ImportTest::pub_call_public_fn	+368 ❌	+114.29%
AvmTest::create_same_nullifier_in_nested_call	+368 ❌	+111.85%
AvmTest::create_different_nullifier_in_nested_call	+368 ❌	+108.24%
Parent::public_static_call	+554 ❌	+105.52%
StaticParent::public_static_call	+554 ❌	+105.52%
TokenBridge::_call_mint_on_token	+539 ❌	+69.91%
Child::set_value_twice_with_nested_last	+363 ❌	+63.68%
Child::set_value_twice_with_nested_first	+363 ❌	+63.68%
Lending::repay_public	+728 ❌	+56.52%
Lending::deposit_public	+728 ❌	+49.93%
AvmInitializerTest::constructor	+1,357 ❌	+48.05%
StaticParent::public_nested_static_call	+452 ❌	+42.05%
Lending::withdraw_public	+364 ❌	+39.18%
Lending::borrow_public	+364 ❌	+39.18%
FPC::prepare_fee	+378 ❌	+37.72%
AvmInitializerTest::public_dispatch	+1,371 ❌	+37.71%
AuthWitTest::public_dispatch	+618 ❌	+35.23%
FPC::pay_refund_with_shielded_rebate	+415 ❌	+33.15%
DocsExample::get_shared_immutable_constrained_public_indirect	+122 ❌	+29.98%
ImportTest::public_dispatch	+405 ❌	+29.31%
FPC::pay_refund	+401 ❌	+29.12%
Uniswap::_assert_token_is_same	+127 ❌	+28.60%
StaticParent::public_dispatch	+1,633 ❌	+23.59%
Parent::public_dispatch	+1,941 ❌	+19.13%
Child::set_value_with_two_nested_calls	+119 ❌	+18.06%
Child::public_dispatch	+862 ❌	+17.51%
Parent::public_nested_static_call	+604 ❌	+15.01%
NFT::transfer_in_public	+753 ❌	+14.85%
Uniswap::swap_public	+1,876 ❌	+13.08%
Token::burn_public	+833 ❌	+12.20%
FPC::public_dispatch	+1,254 ❌	+11.47%
StatefulTest::public_constructor	+419 ❌	+9.92%
Token::shield	+809 ❌	+9.63%
Benchmarking::increment_balance	+345 ❌	+9.34%
AvmTest::public_dispatch	+8,308 ❌	+9.27%
Lending::_withdraw	+1,047 ❌	+8.21%
Token::transfer_public	+753 ❌	+8.14%
Lending::public_dispatch	+5,933 ❌	+7.86%
TokenBlacklist::public_dispatch	+9,961 ❌	+7.48%
TokenBridge::exit_to_l1_public	+546 ❌	+7.04%
AvmTest::test_get_contract_instance	+56 ❌	+6.66%
TokenBlacklist::burn_public	+686 ❌	+6.46%
Benchmarking::public_dispatch	+429 ❌	+6.37%
StatefulTest::public_dispatch	+769 ❌	+6.30%
Lending::_borrow	+929 ❌	+6.26%
StaticChild::public_dispatch	+224 ❌	+6.09%
DocsExample::public_dispatch	+346 ❌	+5.98%
TokenBridge::public_dispatch	+1,833 ❌	+5.83%
TokenBlacklist::shield	+662 ❌	+5.46%
TokenBridge::claim_public	+695 ❌	+4.77%
Token::public_dispatch	+2,935 ❌	+4.50%
DelegatedOn::public_dispatch	+56 ❌	+4.46%
Token::complete_refund	+140 ❌	+4.17%
Delegator::public_dispatch	+84 ❌	+4.15%
Crowdfunding::public_dispatch	+335 ❌	+4.10%
TokenBlacklist::transfer_public	+648 ❌	+4.05%
Test::public_dispatch	+1,274 ❌	+3.88%
AvmTest::test_get_contract_instance_raw	+14 ❌	+3.84%
PrivateFPC::constructor	+154 ❌	+3.81%
PrivateFPC::public_dispatch	+196 ❌	+3.77%
TokenBridge::constructor	+154 ❌	+3.68%
TestLog::public_dispatch	+126 ❌	+3.65%
Router::public_dispatch	+140 ❌	+3.64%
NFT::public_dispatch	+1,394 ❌	+3.56%
Claim::public_dispatch	+196 ❌	+3.47%
EasyPrivateVoting::public_dispatch	+314 ❌	+3.42%
Claim::constructor	+154 ❌	+3.42%
AvmTest::assert_calldata_copy	+14 ❌	+3.28%
NFT::constructor	+237 ❌	+3.25%
AvmTest::variable_base_msm	+14 ❌	+3.17%
AvmTest::bulk_testing	+971 ❌	+3.09%
Token::constructor	+237 ❌	+3.04%
Auth::public_dispatch	+958 ❌	+2.95%
AvmTest::emit_unencrypted_log	+84 ❌	+2.87%
TokenBlacklist::constructor	+461 ❌	+2.83%
Test::consume_mint_public_message	+336 ❌	+2.51%
Router::_check_block_number	+28 ❌	+2.37%
AvmTest::sha256_hash	+84 ❌	+2.36%
Router::_check_timestamp	+28 ❌	+2.34%
Test::consume_message_from_arbitrary_sender_public	+182 ❌	+2.10%
PriceFeed::public_dispatch	+98 ❌	+1.99%
Auth::set_authorized_delay	+224 ❌	+1.96%
AvmTest::u128_from_integer_overflow	+14 ❌	+1.94%
Auth::set_authorized	+224 ❌	+1.93%
FeeJuice::public_dispatch	+182 ❌	+1.84%
InclusionProofs::public_dispatch	+103 ❌	+1.83%
Test::create_l2_to_l1_message_public	+42 ❌	+1.80%
NFT::finalize_transfer_to_private	+98 ❌	+1.75%
Test::emit_unencrypted	+28 ❌	+1.73%
TokenBlacklist::update_roles	+266 ❌	+1.63%
AuthRegistry::public_dispatch	+378 ❌	+1.63%
Auth::get_scheduled_authorized	+42 ❌	+1.60%
Auth::get_authorized	+42 ❌	+1.54%
Lending::_deposit	+38 ❌	+1.53%
TokenBlacklist::mint_private	+98 ❌	+1.48%
AppSubscription::public_dispatch	+116 ❌	+1.45%
Auth::get_authorized_delay	+42 ❌	+1.41%
Crowdfunding::init	+69 ❌	+1.36%
TestLog::emit_unencrypted_events	+28 ❌	+1.31%
CardGame::on_cards_claimed	+98 ❌	+1.31%
Lending::_repay	+122 ❌	+1.30%
Token::mint_private	+56 ❌	+1.28%
AvmTest::pedersen_hash_with_index	+42 ❌	+1.23%
AvmTest::pedersen_hash	+42 ❌	+1.23%
AppSubscription::constructor	+74 ❌	+1.23%
CardGame::on_card_played	+70 ❌	+1.18%
CardGame::on_game_joined	+56 ❌	+1.17%
AvmTest::get_args_hash	+19 ❌	+1.16%
Crowdfunding::_publish_donation_receipts	+14 ❌	+1.10%
AvmTest::u128_addition_overflow	+14 ❌	+1.03%
AuthRegistry::consume	+84 ❌	+1.02%
TokenBlacklist::get_roles	+42 ❌	+1.01%
CardGame::start_game	+70 ❌	+0.96%
Spam::public_dispatch	+42 ❌	+0.92%
TokenBlacklist::mint_public	+84 ❌	+0.80%
AvmTest::keccak_hash	+14 ❌	+0.51%
CardGame::public_dispatch	+122 ❌	+0.43%
EasyPrivateVoting::constructor	-16 ✅	-0.36%
Auth::constructor	-16 ✅	-0.39%
FPC::constructor	-16 ✅	-0.39%
Uniswap::constructor	-16 ✅	-0.39%
InclusionProofs::constructor	-16 ✅	-0.43%
Uniswap::public_dispatch	-180 ✅	-0.56%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1	-2,576 ✅	-29.04%

Full diff report 👇

Program	Bytecode size in bytes (+/-)	%
AvmTest::pedersen_commit	1,465 (+1,115)	+318.57%
AvmTest::nested_call_to_add_with_gas	1,019 (+656)	+180.72%
AvmTest::nested_static_call_to_add	1,002 (+628)	+167.91%
AvmTest::nested_call_to_add	1,002 (+628)	+167.91%
AuthWitTest::consume_public	1,007 (+586)	+139.19%
StaticParent::public_get_value_from_child	806 (+447)	+124.51%
Parent::pub_entry_point_twice	1,215 (+673)	+124.17%
Parent::pub_entry_point	801 (+433)	+117.66%
StaticParent::public_call	801 (+433)	+117.66%
AvmTest::nested_static_call_to_set_storage	689 (+368)	+114.64%
ImportTest::pub_call_public_fn	690 (+368)	+114.29%
AvmTest::create_same_nullifier_in_nested_call	697 (+368)	+111.85%
AvmTest::create_different_nullifier_in_nested_call	708 (+368)	+108.24%
Parent::public_static_call	1,079 (+554)	+105.52%
StaticParent::public_static_call	1,079 (+554)	+105.52%
TokenBridge::_call_mint_on_token	1,310 (+539)	+69.91%
Child::set_value_twice_with_nested_last	933 (+363)	+63.68%
Child::set_value_twice_with_nested_first	933 (+363)	+63.68%
Lending::repay_public	2,016 (+728)	+56.52%
Lending::deposit_public	2,186 (+728)	+49.93%
AvmInitializerTest::constructor	4,181 (+1,357)	+48.05%
StaticParent::public_nested_static_call	1,527 (+452)	+42.05%
Lending::withdraw_public	1,293 (+364)	+39.18%
Lending::borrow_public	1,293 (+364)	+39.18%
FPC::prepare_fee	1,380 (+378)	+37.72%
AvmInitializerTest::public_dispatch	5,007 (+1,371)	+37.71%
AuthWitTest::public_dispatch	2,372 (+618)	+35.23%
FPC::pay_refund_with_shielded_rebate	1,667 (+415)	+33.15%
DocsExample::get_shared_immutable_constrained_public_indirect	529 (+122)	+29.98%
ImportTest::public_dispatch	1,787 (+405)	+29.31%
FPC::pay_refund	1,778 (+401)	+29.12%
Uniswap::_assert_token_is_same	571 (+127)	+28.60%
StaticParent::public_dispatch	8,554 (+1,633)	+23.59%
Parent::public_dispatch	12,086 (+1,941)	+19.13%
Child::set_value_with_two_nested_calls	778 (+119)	+18.06%
Child::public_dispatch	5,784 (+862)	+17.51%
Parent::public_nested_static_call	4,628 (+604)	+15.01%
NFT::transfer_in_public	5,824 (+753)	+14.85%
Uniswap::swap_public	16,218 (+1,876)	+13.08%
Token::burn_public	7,661 (+833)	+12.20%
FPC::public_dispatch	12,185 (+1,254)	+11.47%
StatefulTest::public_constructor	4,644 (+419)	+9.92%
Token::shield	9,206 (+809)	+9.63%
Benchmarking::increment_balance	4,039 (+345)	+9.34%
AvmTest::public_dispatch	97,970 (+8,308)	+9.27%
Lending::_withdraw	13,801 (+1,047)	+8.21%
Token::transfer_public	10,002 (+753)	+8.14%
Lending::public_dispatch	81,457 (+5,933)	+7.86%
TokenBlacklist::public_dispatch	143,090 (+9,961)	+7.48%
TokenBridge::exit_to_l1_public	8,307 (+546)	+7.04%
AvmTest::test_get_contract_instance	897 (+56)	+6.66%
TokenBlacklist::burn_public	11,310 (+686)	+6.46%
Benchmarking::public_dispatch	7,163 (+429)	+6.37%
StatefulTest::public_dispatch	12,975 (+769)	+6.30%
Lending::_borrow	15,767 (+929)	+6.26%
StaticChild::public_dispatch	3,903 (+224)	+6.09%
DocsExample::public_dispatch	6,128 (+346)	+5.98%
TokenBridge::public_dispatch	33,276 (+1,833)	+5.83%
TokenBlacklist::shield	12,794 (+662)	+5.46%
TokenBridge::claim_public	15,252 (+695)	+4.77%
Token::public_dispatch	68,158 (+2,935)	+4.50%
DelegatedOn::public_dispatch	1,312 (+56)	+4.46%
Token::complete_refund	3,496 (+140)	+4.17%
Delegator::public_dispatch	2,109 (+84)	+4.15%
Crowdfunding::public_dispatch	8,498 (+335)	+4.10%
TokenBlacklist::transfer_public	16,661 (+648)	+4.05%
Test::public_dispatch	34,124 (+1,274)	+3.88%
AvmTest::test_get_contract_instance_raw	379 (+14)	+3.84%
PrivateFPC::constructor	4,198 (+154)	+3.81%
PrivateFPC::public_dispatch	5,390 (+196)	+3.77%
TokenBridge::constructor	4,336 (+154)	+3.68%
TestLog::public_dispatch	3,581 (+126)	+3.65%
Router::public_dispatch	3,987 (+140)	+3.64%
NFT::public_dispatch	40,605 (+1,394)	+3.56%
Claim::public_dispatch	5,851 (+196)	+3.47%
EasyPrivateVoting::public_dispatch	9,491 (+314)	+3.42%
Claim::constructor	4,659 (+154)	+3.42%
AvmTest::assert_calldata_copy	441 (+14)	+3.28%
NFT::constructor	7,536 (+237)	+3.25%
AvmTest::variable_base_msm	456 (+14)	+3.17%
AvmTest::bulk_testing	32,429 (+971)	+3.09%
Token::constructor	8,025 (+237)	+3.04%
Auth::public_dispatch	33,435 (+958)	+2.95%
AvmTest::emit_unencrypted_log	3,011 (+84)	+2.87%
TokenBlacklist::constructor	16,767 (+461)	+2.83%
Test::consume_mint_public_message	13,747 (+336)	+2.51%
Router::_check_block_number	1,208 (+28)	+2.37%
AvmTest::sha256_hash	3,649 (+84)	+2.36%
Router::_check_timestamp	1,225 (+28)	+2.34%
Test::consume_message_from_arbitrary_sender_public	8,838 (+182)	+2.10%
PriceFeed::public_dispatch	5,033 (+98)	+1.99%
Auth::set_authorized_delay	11,646 (+224)	+1.96%
AvmTest::u128_from_integer_overflow	737 (+14)	+1.94%
Auth::set_authorized	11,842 (+224)	+1.93%
FeeJuice::public_dispatch	10,057 (+182)	+1.84%
InclusionProofs::public_dispatch	5,733 (+103)	+1.83%
Test::create_l2_to_l1_message_public	2,372 (+42)	+1.80%
NFT::finalize_transfer_to_private	5,683 (+98)	+1.75%
Test::emit_unencrypted	1,651 (+28)	+1.73%
TokenBlacklist::update_roles	16,550 (+266)	+1.63%
AuthRegistry::public_dispatch	23,629 (+378)	+1.63%
Auth::get_scheduled_authorized	2,666 (+42)	+1.60%
Auth::get_authorized	2,762 (+42)	+1.54%
Lending::_deposit	2,517 (+38)	+1.53%
TokenBlacklist::mint_private	6,729 (+98)	+1.48%
AppSubscription::public_dispatch	8,106 (+116)	+1.45%
Auth::get_authorized_delay	3,027 (+42)	+1.41%
Crowdfunding::init	5,148 (+69)	+1.36%
TestLog::emit_unencrypted_events	2,158 (+28)	+1.31%
CardGame::on_cards_claimed	7,573 (+98)	+1.31%
Lending::_repay	9,484 (+122)	+1.30%
Token::mint_private	4,443 (+56)	+1.28%
AvmTest::pedersen_hash_with_index	3,443 (+42)	+1.23%
AvmTest::pedersen_hash	3,443 (+42)	+1.23%
AppSubscription::constructor	6,095 (+74)	+1.23%
CardGame::on_card_played	5,978 (+70)	+1.18%
CardGame::on_game_joined	4,823 (+56)	+1.17%
AvmTest::get_args_hash	1,651 (+19)	+1.16%
Crowdfunding::_publish_donation_receipts	1,290 (+14)	+1.10%
AvmTest::u128_addition_overflow	1,371 (+14)	+1.03%
AuthRegistry::consume	8,342 (+84)	+1.02%
TokenBlacklist::get_roles	4,216 (+42)	+1.01%
CardGame::start_game	7,355 (+70)	+0.96%
Spam::public_dispatch	4,604 (+42)	+0.92%
TokenBlacklist::mint_public	10,613 (+84)	+0.80%
AvmTest::keccak_hash	2,733 (+14)	+0.51%
CardGame::public_dispatch	28,278 (+122)	+0.43%
EasyPrivateVoting::constructor	4,374 (-16)	-0.36%
Auth::constructor	4,119 (-16)	-0.39%
FPC::constructor	4,097 (-16)	-0.39%
Uniswap::constructor	4,097 (-16)	-0.39%
InclusionProofs::constructor	3,699 (-16)	-0.43%
Uniswap::public_dispatch	31,839 (-180)	-0.56%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1	6,295 (-2,576)	-29.04%

dbanks12

I know this isn't ready yet, but I decided to skim anyway because I'm curious. Nice work so far!

dbanks12 · 2024-09-27T19:10:29Z

-impl <let N: u32> Deserialize<N> for str<N> {
-    fn deserialize(fields: [Field; N]) -> Self {
-        str<N>::from(fields.map(|value| value as u8))
+impl <let N: u32> Deserialize<1> for str<31> {
+    fn deserialize(fields: [Field; 1]) -> Self {
+        fields[0].to_be_bytes().as_str_unchecked()


dbanks12 · 2024-09-27T19:11:22Z

-    return {
-      name: this.functionDao.name,
-      args,
-      selector: FunctionSelector.fromNameAndParameters(this.functionDao.name, this.functionDao.parameters),
-      type: this.functionDao.functionType,
-      to: this.contractAddress,
-      isStatic: this.functionDao.isStatic,
-      returnTypes: this.functionDao.returnTypes,
-    };
+    if (this.functionDao.functionType === FunctionType.PUBLIC) {
+      // Redirect through dispatch function.
+      const originalSelector = FunctionSelector.fromNameAndParameters(
+        this.functionDao.name,
+        this.functionDao.parameters,
+      );
+      const dispatchSelector = FunctionSelector.fromSignature('public_dispatch(Field)');
+      return {
+        name: this.functionDao.name,
+        args: [originalSelector.toField(), ...args],
+        selector: dispatchSelector,
+        type: this.functionDao.functionType,
+        to: this.contractAddress,
+        isStatic: this.functionDao.isStatic,
+        returnTypes: this.functionDao.returnTypes,
+      };
+    } else {
+      return {
+        name: this.functionDao.name,
+        args,
+        selector: FunctionSelector.fromNameAndParameters(this.functionDao.name, this.functionDao.parameters),
+        type: this.functionDao.functionType,
+        to: this.contractAddress,
+        isStatic: this.functionDao.isStatic,
+        returnTypes: this.functionDao.returnTypes,
+      };
+    }


makes sense

github-actions · 2024-09-30T18:42:00Z

Changes to circuit sizes

Generated at commit: 8e746cc2a4247edafad791ce6fb0df7bf77f7d4e, compared to commit: 089dbadd9e9ca304004c38e01d3703d923b257ec

🧾 Summary (100% most significant diffs)

Program	%	Circuit size (+/-)	%
parity_root	0.00%	+1,669,803 ❌	+43.75%
rollup_block_root	0.00%	+1,252,353 ❌	+43.65%
rollup_merge	0.00%	+834,903 ❌	+43.56%
rollup_root	0.00%	+834,902 ❌	+42.76%
rollup_block_merge	0.00%	+834,902 ❌	+42.75%
public_kernel_merge	0.00%	+417,452 ❌	+37.35%
public_kernel_tail	0.00%	+417,452 ❌	+18.30%
rollup_base	0.00%	+417,450 ❌	+12.59%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
parity_root	2,114 (0)	0.00%	5,486,726 (+1,669,803)	+43.75%
rollup_block_root	1,966 (0)	0.00%	4,121,156 (+1,252,353)	+43.65%
rollup_merge	1,483 (0)	0.00%	2,751,430 (+834,903)	+43.56%
rollup_root	18,844 (0)	0.00%	2,787,657 (+834,902)	+42.76%
rollup_block_merge	18,860 (0)	0.00%	2,787,689 (+834,902)	+42.75%
public_kernel_merge	53,488 (0)	0.00%	1,535,245 (+417,452)	+37.35%
public_kernel_tail	259,172 (0)	0.00%	2,699,168 (+417,452)	+18.30%
rollup_base	423,026 (0)	0.00%	3,734,192 (+417,450)	+12.59%

fcarreiro mentioned this pull request Sep 26, 2024

feat(aztec-nr/public): dispatch function #8821

Merged

fcarreiro force-pushed the fc/avm-dispatch-changes branch from eb622b7 to 1d84218 Compare September 26, 2024 13:53

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 25751b2 to 951c7ba Compare September 26, 2024 13:53

fcarreiro force-pushed the fc/avm-dispatch-changes branch from 1d84218 to 9c2dba2 Compare September 26, 2024 14:09

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 951c7ba to 4eb92d8 Compare September 26, 2024 14:09

fcarreiro force-pushed the fc/avm-dispatch-changes branch from 9c2dba2 to 89689e0 Compare September 26, 2024 14:15

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 4eb92d8 to 86a27d6 Compare September 26, 2024 14:16

fcarreiro force-pushed the fc/avm-dispatch-changes branch from 89689e0 to 8c26a59 Compare September 26, 2024 14:18

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 86a27d6 to b7150b9 Compare September 26, 2024 14:18

fcarreiro force-pushed the fc/avm-dispatch-changes branch from 8c26a59 to d37a0fa Compare September 26, 2024 14:23

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from b7150b9 to 6ef1696 Compare September 26, 2024 14:23

fcarreiro force-pushed the fc/avm-dispatch-changes branch from d37a0fa to c09ef97 Compare September 26, 2024 14:40

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 6ef1696 to b840458 Compare September 26, 2024 14:40

fcarreiro changed the title ~~feat(avm)!: dispatch transition 1~~ feat!: dispatch transition 1 Sep 26, 2024

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from b840458 to 950159e Compare September 26, 2024 15:21

fcarreiro force-pushed the fc/avm-dispatch-changes branch from e7d72b8 to e602516 Compare September 26, 2024 15:34

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch 4 times, most recently from b12db30 to 8193546 Compare September 26, 2024 17:00

fcarreiro force-pushed the fc/avm-dispatch-changes branch from c4f547f to cc5b604 Compare September 27, 2024 09:41

fcarreiro changed the base branch from fc/avm-dispatch-changes to graphite-base/8824 September 27, 2024 10:47

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 8193546 to 545dd6a Compare September 27, 2024 11:59

fcarreiro force-pushed the graphite-base/8824 branch from cc5b604 to 3af2381 Compare September 27, 2024 11:59

fcarreiro changed the base branch from graphite-base/8824 to master September 27, 2024 11:59

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 545dd6a to 7df18de Compare September 27, 2024 14:37

fcarreiro changed the title ~~feat!: dispatch transition 1~~ [DO NOT MERGE] feat!: dispatch transition (first pass) Sep 27, 2024

fcarreiro marked this pull request as ready for review September 27, 2024 14:37

fcarreiro requested a review from dbanks12 as a code owner September 27, 2024 14:37

fcarreiro removed the request for review from dbanks12 September 27, 2024 14:37

dbanks12 reviewed Sep 27, 2024

View reviewed changes

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch 3 times, most recently from 75deffc to 6f01fe5 Compare September 30, 2024 10:30

fcarreiro added the e2e-all label Sep 30, 2024 — with Graphite App

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 12857e6 to 6eb5839 Compare September 30, 2024 18:24

fcarreiro added 8 commits October 1, 2024 12:35

wip

301ebd0

authwit

31bce43

only deploy public_dispatch for public

eb6783e

fix serializations

619b2bc

fix enqueue from private

09b3f63

void private calls

8799f74

more interface changes

edc5465

towards fixing fees

51ac58c

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from 718cd7c to 71b87ee Compare October 1, 2024 14:56

fcarreiro marked this pull request as draft October 2, 2024 11:36

fix fees

f8b659b

fcarreiro force-pushed the fc/avm-dispatch-transition-1 branch from b7f1f4b to f8b659b Compare October 2, 2024 12:39

fcarreiro closed this Oct 2, 2024

fcarreiro deleted the fc/avm-dispatch-transition-1 branch November 18, 2024 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] feat!: dispatch transition (first pass)#8824

[DO NOT MERGE] feat!: dispatch transition (first pass)#8824
fcarreiro wants to merge 9 commits into
masterfrom
fc/avm-dispatch-transition-1

fcarreiro commented Sep 26, 2024

Uh oh!

fcarreiro commented Sep 26, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

dbanks12 left a comment

Uh oh!

dbanks12 Sep 27, 2024

Uh oh!

dbanks12 Sep 27, 2024

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fcarreiro commented Sep 26, 2024

Uh oh!

fcarreiro commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to public function bytecode sizes

🧾 Summary (100% most significant diffs)

Uh oh!

dbanks12 left a comment

Choose a reason for hiding this comment

Uh oh!

dbanks12 Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

dbanks12 Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fcarreiro commented Sep 26, 2024 •

edited

Loading

github-actions Bot commented Sep 27, 2024 •

edited

Loading

github-actions Bot commented Sep 30, 2024 •

edited

Loading