feat: naive attempt to bind the honk solidity verifier function to the ts interface#9432
Merged
Conversation
Contributor
Author
|
can't believe it worked first thing 😲 |
Collaborator
|
Hey, how was this tested? |
lucasxia01
reviewed
Oct 25, 2024
Contributor
Author
I tested manually in a noir-starter branch. Figured since there wasn't a test for the UP solidity verifier (I think?) I could get away without one for Honk too. Didn't get too deep into the matter, just wanted to save you guys some time with some quick plumbing |
lucasxia01
approved these changes
Nov 7, 2024
signorecello
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
signorecello
force-pushed
the
zpedro/c_bind_honk_verifier
branch
from
95b46c9 to
6bd8c6e
Compare
TomAFrench
added a commit
that referenced
this pull request
Nov 13, 2024
* master: fix: TXE fixes (#9930) chore: pull noir PR #6461 from sync PR (#9923) chore: update version numbers of noir packages (#9922) chore: pull doc changes out of sync PR (#9921) feat: naive attempt to bind the honk solidity verifier function to the ts interface (#9432) fix: update cli-wallet bash tests to reflect token contract changes (#9927)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to plumb the honk solidity verifier into the WASM output and expose it in the ts API