Update trees as we generate blocks#96
Merged
Merged
Conversation
spalladino
force-pushed
the
palla/update-trees-during-block-building
branch
from
0b120ce to
6f3bfb2
Compare
spalladino
force-pushed
the
palla/update-trees-during-block-building
branch
2 times, most recently
from
74e04ef to
9c6f47c
Compare
spalladino
force-pushed
the
palla/update-trees-during-block-building
branch
from
9c6f47c to
2b61f99
Compare
spalladino
changed the title
…during-block-building
…during-block-building
…during-block-building
ludamad
added a commit
that referenced
this pull request
Apr 14, 2023
* chore: add workspace * chore: circuits c++ config
ludamad
added a commit
that referenced
this pull request
Apr 17, 2023
* chore: add workspace * chore: circuits c++ config
ludamad
added a commit
that referenced
this pull request
Apr 17, 2023
* chore: add workspace * chore: circuits c++ config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup circuit inputs need the latest info from the trees, so we need to update them as we build the inputs to the circuit. This also gives us the chance to validate that the trees we've calculated match the output of the circuit simulations.