chore: fixing test contract fixture#9909
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sklppy88
force-pushed
the
ek/chore/fix-test-contract-fixture
branch
from
ec72ad7 to
c4544b9
Compare
This was referenced Nov 12, 2024
sklppy88
force-pushed
the
ek/chore/fix-test-contract-fixture
branch
from
c4544b9 to
4aea1b9
Compare
Contributor
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
sklppy88
force-pushed
the
ek/chore/fix-test-contract-fixture
branch
from
4aea1b9 to
7482995
Compare
sklppy88
force-pushed
the
ek/chore/fix-test-contract-fixture
branch
from
7482995 to
4bf0326
Compare
sklppy88
commented
Nov 13, 2024
| expect(artifact.functions.filter(isUnconstrained).length).toBe(1); | ||
|
|
||
| const unconstrainedFunction = unconstrainedFns[0]; | ||
| const selector = FunctionSelector.fromNameAndParameters(unconstrainedFunction); |
Contributor
Author
There was a problem hiding this comment.
This needed to be fixed because previously it was using the selector set on L24 which is not the same selector as the unconstrained function set here !
benesjan
approved these changes
Nov 13, 2024
stevenplatt
pushed a commit
that referenced
this pull request
Nov 13, 2024
This just fixes a utility function that seems to be a typo, as it is has the same content as the function above it, and uses the same artifact. This also bumps the timeout of `pxe.test.ts` because we were seeing some issues in timeouts with adding contract artifact.
TomAFrench
added a commit
that referenced
this pull request
Nov 14, 2024
* master: (245 commits) chore: pull signed bitshifts from sync PR (#9939) chore: pull frontend changes from sync PR (#9935) feat: separate bytecode logs from unencrypted logs (#9891) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: token naming issue (#9950) feat: multiplier oracle (#9902) refactor: token refunds cleanup (#9943) chore: Use stack based recursion instead of function recursion (#9947) feat: parallelize DIE pass (#9933) feat(avm): Simulator enforces integral tag for DIV and field tag for FDIV (#9944) chore(avm): bugfixing witness generation for add, sub, mul for FF (#9938) feat: Google Cloud Kubernetes cluster + AWS Firewall Rules (#9915) chore: nuking ancient redundant test (#9941) fix: include 'master' version for aztec-up scripts (#9940) chore: fixing test contract fixture (#9909) refactor: token naming cleanup (#9904) chore: pull SSA parser from sync PR (#9928) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just fixes a utility function that seems to be a typo, as it is has the same content as the function above it, and uses the same artifact. This also bumps the timeout of
pxe.test.tsbecause we were seeing some issues in timeouts with adding contract artifact.