Skip to content

refactor: enqueued calls processor -> public tx simulator#9919

Merged
dbanks12 merged 1 commit into
masterfrom
db/refactor-enqueued-calls-processor
Nov 15, 2024
Merged

refactor: enqueued calls processor -> public tx simulator#9919
dbanks12 merged 1 commit into
masterfrom
db/refactor-enqueued-calls-processor

Conversation

@dbanks12

@dbanks12 dbanks12 commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Rename EnqueuedCallsProcessor -> PublicTxSimulator
  • Introduce PublicTxContext
  • Refactor EnqueuedCallsProcessor with functions per phase that use PublicTxContext
  • Split up tracing of enqueued calls and the merging of their state & traces (too confusing if they're coupled)
  • Lots of prep for removal of public kernels
  • Misc cleanup

Peek at the other PRs in this stack to see how things will simplify further!

I am open to all feedback when it comes to the refactor of EnqueuedCallsProcessor, this new PublicTxContext, state forking, etc.

@dbanks12 dbanks12 requested a review from fcarreiro as a code owner November 13, 2024 03:01
@dbanks12 dbanks12 removed the request for review from fcarreiro November 13, 2024 13:38
@dbanks12 dbanks12 mentioned this pull request Nov 14, 2024
Closed
@dbanks12 dbanks12 force-pushed the db/refactor-enqueued-calls-processor branch from de18982 to 1ff73fb Compare November 14, 2024 17:20
@dbanks12 Graphite App

dbanks12 commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dbanks12 dbanks12 mentioned this pull request Nov 14, 2024
Merged
@dbanks12 dbanks12 force-pushed the db/refactor-enqueued-calls-processor branch from 1ff73fb to eeba295 Compare November 14, 2024 18:17
@dbanks12 dbanks12 force-pushed the db/refactor-enqueued-calls-processor branch 4 times, most recently from 405bc84 to 065a139 Compare November 14, 2024 20:48
@dbanks12 dbanks12 force-pushed the db/refactor-enqueued-calls-processor branch from 065a139 to 889d1c9 Compare November 14, 2024 20:50
@dbanks12 dbanks12 mentioned this pull request Nov 15, 2024
Merged
@dbanks12 dbanks12 changed the title [WIP] refactor: enqueued calls processor refactor: enqueued calls processor -> public tx simulator Nov 15, 2024
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/enqueued_call_side_effect_trace.ts
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/enqueued_calls_processor.ts
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/public_tx_context.ts
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/public_tx_context.ts
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
Comment on lines +177 to +178
const callRequests = context.getCallRequestsForCurrentPhase();
const executionRequests = context.getExecutionRequestsForCurrentPhase();

@dbanks12 dbanks12 Nov 15, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all we need from PublicExecutionRequests is args, we probably can just work with PublicCallRequests & args instead of PublicCallRequests & PublicExecutionRequests

dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
dbanks12
dbanks12 commented Nov 15, 2024
View reviewed changes
Comment thread yarn-project/simulator/src/public/utils.ts
fcarreiro
fcarreiro reviewed Nov 15, 2024
View reviewed changes

@fcarreiro fcarreiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think it looks better. It would be great if we could get rid of some of the duplicated phase-tracking logic though.

Comment thread yarn-project/simulator/src/public/public_tx_context.ts
Comment thread yarn-project/simulator/src/public/public_tx_context.ts

@fcarreiro fcarreiro Nov 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some docstrings on the classes?

Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
Comment thread yarn-project/simulator/src/public/public_tx_simulator.ts
Comment thread yarn-project/simulator/src/public/public_tx_context.ts
import { PublicSideEffectTrace } from './side_effect_trace.js';
import { getCallRequestsByPhase, getExecutionRequestsByPhase, getPublicKernelCircuitPublicInputs } from './utils.js';

class PhaseStateManager {

@fcarreiro fcarreiro Nov 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this class?

Comment thread yarn-project/simulator/src/public/public_tx_context.ts
Comment thread yarn-project/simulator/src/public/utils.ts
LeilaWang
LeilaWang reviewed Nov 15, 2024
View reviewed changes

@LeilaWang LeilaWang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Facundo's comments on explicitly specifying phase and making only one component manage the phases (if possible). Rest looks great to me! Nice refactoring 🎉

@dbanks12 dbanks12 requested a review from fcarreiro November 15, 2024 14:40
fcarreiro
fcarreiro approved these changes Nov 15, 2024
View reviewed changes

@fcarreiro fcarreiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the oath that the comments will be resolved in another PR ;)

@dbanks12 dbanks12 merged commit cae7279 into master Nov 15, 2024
@dbanks12 dbanks12 deleted the db/refactor-enqueued-calls-processor branch November 15, 2024 15:10
@AztecBot AztecBot mentioned this pull request Nov 15, 2024
Merged
@dbanks12 dbanks12 mentioned this pull request Nov 17, 2024
Merged
TomAFrench added a commit that referenced this pull request Nov 18, 2024
@TomAFrench
Merge branch 'master' into sync-noir
4d49f2b 
* master: (281 commits)
  fix: don't take down runners with faulty runner check (#10019)
  feat(docs): add transaction profiler docs (#9932)
  chore: hotfix runner wait (#10018)
  refactor: remove EnqueuedCallSimulator (#10015)
  refactor: stop calling public kernels (#9971)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore: drop info to verbose in sequencer hot loop (#9983)
  refactor: Trace structure is an object (#10003)
  refactor: enqueued calls processor -> public tx simulator (#9919)
  chore: World state tech debt cleanup 1 (#9561)
  chore(ci): run noir tests in parallel to building e2e tests (#9977)
  Revert "chore: lower throughput of ebs disks" (#9996)
  feat: new proving broker implementation (#9400)
  chore: replace `to_radix` directive with brillig (#9970)
  chore: disable failing 48validator kind test (#9920)
  test: prove one epoch in kind (#9886)
  fix: formatting (#9979)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeilaWang LeilaWang LeilaWang left review comments

@fcarreiro fcarreiro fcarreiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbanks12 @fcarreiro @LeilaWang