972 rename constants#998
Merged
Merged
Conversation
jeanmon
force-pushed
the
jm/972-rename-constants
branch
from
a8e59b6 to
01aeca1
Compare
benesjan
approved these changes
Jul 10, 2023
benesjan
left a comment
benesjan
left a comment
Contributor
There was a problem hiding this comment.
New naming is significantly clearer and the changes seem uncontroversial to me so LGTM!
added 14 commits
July 10, 2023 15:06
…LY_REVEALED_DATA_LENGTH_PER_TX
jeanmon
force-pushed
the
jm/972-rename-constants
branch
from
01aeca1 to
fc9c0a3
Compare
suyash67
reviewed
Jul 10, 2023
| constexpr size_t MAX_PUBLIC_DATA_UPDATE_REQUESTS_PER_CALL = 4; | ||
| constexpr size_t MAX_PUBLIC_DATA_READS_PER_CALL = 4; | ||
|
|
||
| // "PER TRANSACTION" CONSTANTS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #972
Checklist: