Skip to content

test(base): nullifier tree initial tests#131

Merged
Maddiaa0 merged 23 commits into
masterfrom
md/nullifier-tree-tests
Apr 5, 2023
Merged

test(base): nullifier tree initial tests#131
Maddiaa0 merged 23 commits into
masterfrom
md/nullifier-tree-tests

Conversation

@Maddiaa0

@Maddiaa0 Maddiaa0 commented Mar 29, 2023

Copy link
Copy Markdown
Member

Description

NOTE: may be worth holding off on this one, it points to another bb branch that has some more tree additions (frontier path).
Once i test and get these merged into aztec3 we can go back and stay on that branch
pr in question:
AztecProtocol/barretenberg#301

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

@Maddiaa0 Maddiaa0 marked this pull request as draft March 29, 2023 15:09
@Maddiaa0 Maddiaa0 marked this pull request as ready for review March 29, 2023 15:32
Comment thread cpp/src/aztec3/circuits/rollup/base/.test.cpp Outdated
@Maddiaa0 Maddiaa0 marked this pull request as draft March 30, 2023 09:16
@Maddiaa0 Maddiaa0 force-pushed the md/nullifier-tree-tests branch from 992859c to 33e096d Compare March 31, 2023 16:34
@Maddiaa0 Maddiaa0 marked this pull request as ready for review April 3, 2023 11:35
Comment thread cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp
Comment thread cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp
Comment thread cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp Outdated
Comment thread cpp/src/aztec3/circuits/rollup/base/.test.cpp Outdated
Comment thread cpp/src/aztec3/circuits/rollup/base/.test.cpp Outdated
Comment thread cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp Outdated
Comment thread cpp/src/aztec3/circuits/rollup/base/utils.cpp Outdated
Comment thread cpp/src/aztec3/circuits/rollup/base/utils.hpp Outdated
@Maddiaa0 Maddiaa0 merged commit f1599ed into master Apr 5, 2023
@Maddiaa0 Maddiaa0 deleted the md/nullifier-tree-tests branch April 5, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants