Skip to content

Investigate why bincode deserialize is not threadsafe #1395

@ludamad

Description

@ludamad

Caused the browser build to segfault
(However, given the lack of debugging tools we have for WASM, and the fact that it should not be just a WASM build issue, recommend debugging as below)

steps to fix:

  • reintroduce parallel_for in PrivateExecutionSteps::parse(std::vector<PrivateExecutionStepRaw>&& steps)
for (size_t i = 0; i < steps.size(); i++) {
    ...
}

=>

parallel_for(steps.size(), [&](size_t i) {
    ...
});
  • debug using cmake --preset tsan to instrument the code. This should reveal the offending line

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions