Skip to content

feat: Add Noir DSL with acir_format and turbo_proofs namespaces#198

Merged
kevaundray merged 4 commits into
masterfrom
phated/acir-format
Mar 8, 2023
Merged

feat: Add Noir DSL with acir_format and turbo_proofs namespaces#198
kevaundray merged 4 commits into
masterfrom
phated/acir-format

Conversation

@phated

@phated phated commented Mar 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Description

This upstreams the Noir DSL as developed in https://github.com/noir-lang/aztec-connect and attempts to align with the upstream changes (such as passing a nullptr as pippenger_lagrange). I also tried to apply various refactoring and cleanup where possible but my C++ is terrible—so please let me know where things should be better.

This is currently a draft because I think we are going to cleanup some of the turbo_proofs APIs but I need to catch @vezenovm when he is back from EthDenver.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

phated
phated commented Mar 2, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/turbo_proofs/CMakeLists.txt
phated
phated commented Mar 2, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/turbo_proofs/c_bind.cpp Outdated
phated
phated commented Mar 2, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/turbo_proofs/turbo_proofs.cpp Outdated
phated
phated commented Mar 2, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/turbo_proofs/turbo_proofs.cpp Outdated
phated
phated commented Mar 2, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/turbo_proofs/turbo_proofs.cpp Outdated
@phated

phated commented Mar 2, 2023

Copy link
Copy Markdown
Author

I chatted with @vezenovm about which APIs to keep for use in "barretenberg_wrapper" and "barretenberg_wasm" so this is ready for review!

Need to get @kevaundray to review all my refactoring (in case I did something that won't work for Noir) and then crypto-dev folks to review how to make this C++ code better.

@phated phated marked this pull request as ready for review March 2, 2023 23:57
kevaundray
kevaundray reviewed Mar 3, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/acir_format/merkle_insert.hpp Outdated
kevaundray
kevaundray approved these changes Mar 3, 2023
View reviewed changes

@kevaundray kevaundray left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like what we were doing previously with parts of it cleaned up (gracias :) )

@Savio-Sou Savio-Sou modified the milestone: UltraPlonk in Noir Mar 6, 2023
@phated phated requested a review from suyash67 March 6, 2023 15:52
@codygunton codygunton removed their request for review March 6, 2023 20:14
@kevaundray kevaundray mentioned this pull request Mar 7, 2023
Merged
6 tasks
@phated

phated commented Mar 7, 2023

Copy link
Copy Markdown
Author

I'm squashing this all for a rebase on master, so if anyone needs the individual commits, you should look now

@phated phated mentioned this pull request Mar 7, 2023
Merged
11 tasks
@phated phated force-pushed the phated/acir-format branch from f7f0cd1 to 9c67dfe Compare March 7, 2023 19:44
phated
phated commented Mar 7, 2023
View reviewed changes
Comment thread cpp/src/aztec/dsl/acir_format/ecdsa_secp256k1.cpp Outdated
@kevaundray kevaundray merged commit 54fab22 into master Mar 8, 2023
@kevaundray kevaundray deleted the phated/acir-format branch March 8, 2023 18:45
@github-actions github-actions Bot mentioned this pull request Jun 15, 2023
Merged
@github-actions github-actions Bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@phated @kevaundray @vezenovm
feat: Add Noir DSL with acir_format and turbo_proofs namespaces (Azte…
cfcc10a 
…cProtocol/barretenberg#198)

* feat: Add Noir DSL with acir_format and turbo_proofs namespaces

* chore: Upstream changes to fix proving key serialization in turbo_proofs (AztecProtocol/barretenberg#204)
---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@phated @kevaundray @vezenovm
feat: Add Noir DSL with acir_format and turbo_proofs namespaces (Azte…
35c7fcf 
…cProtocol/barretenberg#198)

* feat: Add Noir DSL with acir_format and turbo_proofs namespaces

* chore: Upstream changes to fix proving key serialization in turbo_proofs (AztecProtocol/barretenberg#204)
---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vezenovm vezenovm vezenovm left review comments

@dbanks12 dbanks12 dbanks12 approved these changes

+1 more reviewer

@kevaundray kevaundray kevaundray approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@phated @kevaundray @vezenovm @dbanks12 @Savio-Sou