chore: Upstream changes to fix proving key serialization in turbo_proofs#204
Merged
Conversation
phated
approved these changes
Mar 6, 2023
vezenovm
changed the title
…rypto team how to accurately ecdsa verify_sig with TurboComposer
6 tasks
kevaundray
reviewed
Mar 7, 2023
| pub_key_x_fq.assert_is_in_field(); | ||
| pub_key_y_fq.assert_is_in_field(); | ||
|
|
||
| // TODO: crypto-dev to fix calculation and constraining of the signature result is correct |
There was a problem hiding this comment.
Since this has nothing to do with with the PR title -- I think this should be brought up as an issue on the original PR and we can resolve it there
There was a problem hiding this comment.
@kevaundray this PR is targeting my branch, so we can merge it in now and get it resolved as part of #198
Author
There was a problem hiding this comment.
Ok will bring up as an issue.
Originally these comments were just this line:
auto pub_key = secp256k1_ct::g1_ct(pub_key_x_fq, pub_key_y_fq);
Which was giving unused variable errors, so I did these changes for now.
phated
pushed a commit
that referenced
this pull request
Mar 7, 2023
11 tasks
kevaundray
added a commit
that referenced
this pull request
Mar 8, 2023
* feat: Add Noir DSL with acir_format and turbo_proofs namespaces * chore: Upstream changes to fix proving key serialization in turbo_proofs (#204) --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…cProtocol/barretenberg#198) * feat: Add Noir DSL with acir_format and turbo_proofs namespaces * chore: Upstream changes to fix proving key serialization in turbo_proofs (AztecProtocol/barretenberg#204) --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…cProtocol/barretenberg#198) * feat: Add Noir DSL with acir_format and turbo_proofs namespaces * chore: Upstream changes to fix proving key serialization in turbo_proofs (AztecProtocol/barretenberg#204) --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context can be found here: noir-lang/aztec-connect#26
This PR basically is just making sure to upstream changes being made to
noir-lang/aztec-connectto reduce divergence.Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.