-
Notifications
You must be signed in to change notification settings - Fork 130
Avoiding zero in bach muls #905
Copy link
Copy link
Closed
Labels
auditThings to do during the next auditThings to do during the next auditmerge protocolHaving to do with the goblin EC op merge protocolHaving to do with the goblin EC op merge protocolnice-to-have
Metadata
Metadata
Assignees
Labels
auditThings to do during the next auditThings to do during the next auditmerge protocolHaving to do with the goblin EC op merge protocolHaving to do with the goblin EC op merge protocolnice-to-have
Type
Fields
Give feedbackNo fields configured for issues without a type.
As in the case of AztecProtocol/aztec-packages#5174, we sometimes encounter issues relating to our inability to handle scalar multiplication of EC points in the case where the scalar is 0. I believe: this could be fixed by simply checking whether
z==0before https://github.com/AztecProtocol/aztec-packages/blob/394a0e06928946c1c9eea1bdfec39269cb2d601a/barretenberg/cpp/src/barretenberg/ecc/groups/element_impl.hpp#L68, but we avoid this because of the cost of the check. Someone should determine whether this is really a concern, and if it is, we should identify some hot code paths and use a more robust method outside of those cases.