feat: Utilize globally installed leveldb if available#134
Merged
Conversation
Author
|
It looks like the answer to "what cmake files in docker" is 3.16.3 due to the test failures. |
phated
commented
Feb 9, 2023
phated
force-pushed
the
phated/global-leveldb
branch
from
10f7eb4 to
a9d73d6
Compare
phated
force-pushed
the
phated/global-leveldb
branch
from
a9d73d6 to
9b23037
Compare
dbanks12
approved these changes
Feb 14, 2023
11 tasks
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…barretenberg#134) * feat: Utilize globally installed leveldb if available * chore: Update docs * chore(docker): Update wasm builder to ubuntu:kinetic for newer cmake * chore: Cleanup fragile target linking
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…barretenberg#134) * feat: Utilize globally installed leveldb if available * chore: Update docs * chore(docker): Update wasm builder to ubuntu:kinetic for newer cmake * chore: Cleanup fragile target linking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows leveldb to be provided globally in environments where there is no network access or where the sandbox cannot be changed (e.g. nix) during the building of the package. This is done through
FetchContent_MakeAvailablewhich can be used in combination withFIND_PACKAGE_ARGSto start with afind_packagesearch before trying to fetch from the network.This changes requires a CMake minimum version upgrade because
FIND_PACKAGE_ARGSwasn't added until v3.24 as documented at https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_declare. Does anyone know which version of CMake is being used in the docker containers?Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.