fix: Remove LeveldbStore from stdlib_merkle_tree#149
Merged
Conversation
2f11321 to
79d1433
Compare
Author
|
This has been changed to remove leveldb from BB completely. |
dbanks12
approved these changes
Feb 16, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the
leveldb_storefromstdlib_merkle_treeand removes the workaround injoin_split_examplethat linked leveldb when it wasn't actually used.leveldb is packaged poorly (ref google/leveldb#606 and google/leveldb#920) and mostly unmaintained.
For these reasons, I don't think that leveldb should be part of barretenberg's public interface.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.