chore: Add Ninja generator for wasm & document Ninja requirement for presets#199
Merged
Conversation
Author
|
Looks like Ninja doesn't exist in the wasm docker container. I'll fix. |
phated
commented
Mar 7, 2023
codygunton
approved these changes
Mar 7, 2023
codygunton
left a comment
There was a problem hiding this comment.
Tested this out, works for me, and is much faster than building without ninja via CMake Tools in VS Code.
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At the end of #162, @codygunton said that the wasm preset was slow in VSCode. That is likely due to not using the Ninja generator that @adr1anh added for the default preset (the wasm preset doesn't inherit from default since it is drastically different).
This sets the wasm preset to use the Ninja generator to match the default generator and it documents Ninja as a dependency for the preset workflow. If a user doesn't use the presets for some reason, they will continue to use whatever generator they specify (or their default).
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.