Skip to content

chore: Add Ninja generator for wasm & document Ninja requirement for presets#199

Merged
kevaundray merged 5 commits into
masterfrom
phated/wasm-ninja
Mar 7, 2023
Merged

chore: Add Ninja generator for wasm & document Ninja requirement for presets#199
kevaundray merged 5 commits into
masterfrom
phated/wasm-ninja

Conversation

@phated

@phated phated commented Mar 2, 2023

Copy link
Copy Markdown

Description

At the end of #162, @codygunton said that the wasm preset was slow in VSCode. That is likely due to not using the Ninja generator that @adr1anh added for the default preset (the wasm preset doesn't inherit from default since it is drastically different).

This sets the wasm preset to use the Ninja generator to match the default generator and it documents Ninja as a dependency for the preset workflow. If a user doesn't use the presets for some reason, they will continue to use whatever generator they specify (or their default).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated

phated commented Mar 7, 2023

Copy link
Copy Markdown
Author

Looks like Ninja doesn't exist in the wasm docker container. I'll fix.

Comment thread cpp/dockerfiles/Dockerfile.wasm-linux-clang

@codygunton codygunton left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out, works for me, and is much faster than building without ninja via CMake Tools in VS Code.

@kevaundray kevaundray merged commit ba15855 into master Mar 7, 2023
@kevaundray kevaundray deleted the phated/wasm-ninja branch March 7, 2023 21:52
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants