Skip to content

Acir format failing for certain range constraints#267

Closed
vezenovm wants to merge 40 commits into
mv/move-to-ultrafrom
mv/ultra-range-dbg
Closed

Acir format failing for certain range constraints#267
vezenovm wants to merge 40 commits into
mv/move-to-ultrafrom
mv/ultra-range-dbg

Conversation

@vezenovm

Copy link
Copy Markdown

Description

Debug PR to show how acir_format creates unsatisfiable circuits when dealing with witnesses that are not used in any arithmetic constraints but need to be range constrained.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@vezenovm vezenovm changed the title acir format tests showing failures with range constraints of differen… Acir format failing for certain range constraints Mar 24, 2023
suyash67 and others added 27 commits March 24, 2023 12:29
pedersen hash test now checks y coordinate
wasm code path was not correctly storing fft outputs in proving key
stdlib method is utility method to provide Composer-agnostic interface due to the use of plookup tables if enabled
Updated ReadMe to include wasm example that supports gtest filtering
@phated phated mentioned this pull request Apr 3, 2023
11 tasks
@phated phated deleted the mv/ultra-range-dbg branch April 4, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants