IPA PoC#31
Merged
Merged
Conversation
zac-williamson
requested changes
Jan 9, 2023
zac-williamson
left a comment
There was a problem hiding this comment.
I've left some comments describing future improvements.
The only action items before we merge are to remove the waffle namespace and to tidy up how L_elements and R_elements are populated (directly construct from partial_L and partial_R)
Once this is done I'm happy for the branch to be merged.
However I wouldn't consider this project truly complete until the following points are achieved:
commit,ipa_proveandipa_verifytake in an SRS object instead of a vector of generators (and have this SRS class load the required points from disk like our KZG SRS)- the SRS object contains a single
pippenger_runtime_stateobject that is used to perform all pippenger computations (constructingpippenger_runtime_stateis expensive) - the Fiat-Shamir heuristic is used to generate the round challenges as part of the
ipa_proveandipa_verifyalgorithms. TheInnerProductArgumentclass should have aHashtemplate parameter that defines which hash algorithm is used. - methods are added that batch prove and batch verify multiple polynomial commitments
The above 4 points are required for the IPA commitment scheme to be used in a protocol like Honk or Plonk.
arijitdutta67
added a commit
that referenced
this pull request
Jan 12, 2023
This reverts commit 7ceb0c3.
arijitdutta67
added a commit
that referenced
this pull request
Jan 12, 2023
dbanks12
pushed a commit
that referenced
this pull request
Jan 26, 2023
dbanks12
pushed a commit
that referenced
this pull request
Jan 27, 2023
This was referenced Feb 17, 2023
Closed
Closed
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
PoC version without SRS, Fiat-Shamir, and batching.
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
PoC version without SRS, Fiat-Shamir, and batching.
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a proof of concept version of the inner product argument (IPA) polynomial commitment scheme as in https://eprint.iacr.org/2019/1021.pdf. The spec for the implementation is in https://hackmd.io/q-A8y6aITWyWJrvsGGMWNA?view.