feat: Modify bb.js to be compatible with next.js by jonybur · Pull Request #544 · AztecProtocol/barretenberg

jonybur · 2023-06-18T18:48:18Z

Description

To begin, create a Next.js application and establish a local dependency by linking bb.js to your project.

Should you encounter any difficulties and come across an error indicating the presence of an outdated bb.js installation, remove the .next folder within your Next.js application.

Closes #607.

Checklist:

kevaundray · 2023-06-19T16:03:51Z

Is it possible to have a PR per issue you linked? Asking just based on the line diff, but perhaps both need to be fixed simultaneously.

kevaundray · 2023-06-19T16:06:10Z

Also can you change the title to a conventional commit, so people know if this will be a breaking change to bb.js and roughly what it is doing.

phated · 2023-07-20T21:57:54Z

+    "test:jest": "NODE_NO_WARNINGS=1 node --experimental-vm-modules $(yarn bin jest) --no-cache --passWithNoTests",
    "test:bin": "cd ./bin-test && ./bin-test.sh",
    "test-debug": "NODE_OPTIONS='--loader ts-node/esm' NODE_NO_WARNINGS=1 node --inspect-brk=0.0.0.0 --experimental-vm-modules $(yarn bin jest) --no-cache --passWithNoTests --runInBand",
    "simple_test": "NODE_OPTIONS='--loader ts-node/esm' NODE_NO_WARNINGS=1 node ./src/examples/simple.rawtest.ts",


Let's just remove this so we can drop ts-node

…b/bbjs-cra

ludamad · 2023-07-21T19:29:01Z

Looks good to me overall (looks like just a linter warning now), but would be good to get a look from the initial reviewers

kobyhallx

LGTM 💯

…tenberg#544) Co-authored-by: ludamad <adam.domurad@gmail.com>

Co-authored-by: ludamad <adam.domurad@gmail.com> each subrelation can now choose to not scale relation term by random polynomial permutation relation arithmetic defined exclusively in relationclasses comments, naming cleanup init ecc_vm_relation_test, algebra test passes sumcheck relation test does not wip eccvm, shiftable polynomials now have 0 at first coefficient added clearer comments to eccvm relations removed redundant test files eccvm composer test passes eccvm flavor (+ upstream circuit builder) are parametrised by curve type / commitment scheme wip wip wip wip reduced eccvm relation lengths added more descriptive comments to ecc_set_relation cleaned up sumcheck relation fowarding macros added missing explicit template declarations slight cleanup of method name bloat added missing method removed unused using declaration added explicit `lookup_library.hpp` file to compute logderivative inverses typo fix formatting reversions added ECCVM concepts to flavor removed unused logderivative method each subrelation can now choose to not scale relation term by random polynomial permutation relation arithmetic defined exclusively in relationclasses comments, naming cleanup removed TypeMuncher from relation_types remove foundation blah compiler errors chore: Switch to using `test_data_ssa_refactor` for `acir_tests` (#626) Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com> compile error fix chore(barretenberg): Release 0.3.4 (#618) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> compiler fix compiler fix wasm compiler fix docs: barretenberg README update (#1211) * docs: barretenberg README update * Update README.md docs: update barretenberg integration notes (#1215) This is also just continuing to test the barretenberg mirror. wasm compiler fix feat: internal keyword + lending contract and tests (#978) * feat: noir contracts and test file * feat: include is_internal in kernels * feat: assume isInternal unless told otherwise + update snaps * test: cleanup tests * chore: update noir * chore: recompile noir * fix: rebase issues and clean test * chore: prettier + update name * chore: fix snapshots * fix: add to ci * chore: minor fixes * fix: update noir FunctionData (cannot satisfy 💀) * fix: serialization * fix: bump lending contract * chore: address nits * chore: recompile noir * chore: recompile noir --------- Co-authored-by: Maddiaa0 <47148561+Maddiaa0@users.noreply.github.com> Merge pull request #1235 from AztecProtocol/acvm-0.21.0-compat feat!: update bberg ACIR parser to target ACVM 0.21.0 feat: Goblin Honk Composer/Prover/Verifier (#1220) The Composer, Prover and Verifier for Goblin Ultra Honk. These are implemented as instantiations of the existing "Ultra" template classes, e.g. `GoblinUltraComposer = UltraComposer_<flavor::GoblinUltra>`, etc. This work makes it possible to create and verify a Goblin Ultra Honk proof. "Verification" here means confirmation that the ECC op gates have been correctly incorporated into the circuit (checked via a new relation) plus genuine verification of the conventional UltraHonk proof. The _correctness_ of the the ECC op gates is of course not verified, as that is the role of the other components of the Goblin stack. The new "op gate consistency" relation simply checks that the op wire values have been correctly copied into the conventional wires (needed for copy constraints) and that the op wire polynomials vanish everywhere outside the range of ECC op gates. - [ ] I have reviewed my diff in github, line by line. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience. --------- Co-authored-by: ludamad <adam.domurad@gmail.com> feat: Goblin translator prototype (#1249) Added a prototype of goblin translator with accumulation gate. Automatic formatting when committing caused changes to several files, too - [ ] I have reviewed my diff in github, line by line. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience. fix: Fixing external benchmarks (#1250) Some updates broke internal benchmarks. This fixes them chore: update directory from which to pull noir test cases (#1257) noir-lang/noir#2074 performs a cleanup of the location of the Noir test data directory and so bberg needs to update to match - [x] I have reviewed my diff in github, line by line. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [x] The branch has been merged or rebased against the head of its merge target. - [x] I'm happy for the PR to be merged at the reviewer's next convenience. fix: bootstrap.sh git hook for monorepo (#1256) This had the wrong path inside the monorepo. compiler fix compiler fix fixed error in eccvm lookup relation Merge branch 'master' into zw/eccvm-v2

…ol/barretenberg#544)" This reverts commit 9cf96aa.

jonybur added 8 commits June 16, 2023 22:26

Switch point to be browser compatible

ab016eb

Webpack config changes

e35ae60

Package.json changes

38ab0ea

Add web entrypoint

c51086f

Remove old webpack

2ec7f60

Enable browser imports

5cda723

Remove comment

d5b9d56

Fixes to allow compilation (wip)

914b96d

jonybur changed the title ~~Jb/bbjs cra~~ feat: bbjs compatibility for nextjs Jun 19, 2023

jonybur added 12 commits June 20, 2023 13:48

First working version

068aea5

Readd barretenberg_wasm node code

0aa28fc

Revert node files

dd0cddb

Revret random file

fcb81f9

Revert barretenberg_wasm

3bf4cfc

Revert simple test

45c2fac

Fix type issue

a8fbafb

Adds point for node and browser

9a2131a

Roll back web entrypoint

e174be9

Cleanup

218e7c0

Remove need for config on nextjs

0697d6b

Wasm path fix, wip double target outputs

a91d6f4

Savio-Sou mentioned this pull request Jun 23, 2023

Have workable version of bbjs for nextjs, with custom webpack config on the frontend noir-lang/barretenberg#2

Closed

jonybur added 6 commits June 23, 2023 13:00

Allow multiple targets

80d6a0b

Readd two entrypoints

226f016

Replace imports

557ce64

Add exports to package json

74de092

Fix build

6a503c5

Single entrypoint

dc767bc

Fix tests

b4f20ca

phated reviewed Jul 20, 2023

View reviewed changes

jonybur and others added 16 commits July 20, 2023 22:05

Remove simple.rawtest, ts-node dep, ignore browser/wasm file

4f5f5f9

Merge branch 'master' of github.com:AztecProtocol/barretenberg into j…

6c658a7

…b/bbjs-cra

Remove workflow

ff68b79

Update yarn.lock

68d5cb5

Fix cmake issue

6251826

Add docker history output

30a1e15

Revert docker config

1a93b95

Merge branch 'master' of github.com:AztecProtocol/barretenberg into j…

472ca76

…b/bbjs-cra

Readd cmake

2834f86

Debug information for folders

7002874

Add apk update

4645fe4

Revert acir_tests Dockerfile

fc632ae

Add cmake to ts/Dockerfile

a6c4484

Roll back changes

d3ed0e0

Readd cmake

465cfa1

fix: fix attempts for bbjs-cra branch (#620)

5ca0d26

fix: bbjs with cra

d4dfaef

kobyhallx approved these changes Jul 24, 2023

View reviewed changes

kobyhallx merged commit d384089 into master Jul 24, 2023

kobyhallx deleted the jb/bbjs-cra branch July 24, 2023 14:36

github-actions Bot mentioned this pull request Jul 24, 2023

chore(barretenberg): Release 0.3.4 #618

Merged

ludamad added a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023

feat: Modify bb.js to be compatible with next.js (AztecProtocol/barre…

64a1741

…tenberg#544) Co-authored-by: ludamad <adam.domurad@gmail.com>

ludamad added a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023

feat: Modify bb.js to be compatible with next.js (AztecProtocol/barre…

9cf96aa

…tenberg#544) Co-authored-by: ludamad <adam.domurad@gmail.com>

This was referenced Jul 25, 2023

chore(aztec-sandbox): Release 0.2.0-alpha27 AztecProtocol/aztec-packages#1180

Closed

chore(aztec-sandbox): Release 0.2.0 AztecProtocol/aztec-packages#1181

Closed

charlielye added a commit to AztecProtocol/aztec-packages that referenced this pull request Aug 26, 2023

Revert "feat: Modify bb.js to be compatible with next.js (AztecProtoc…

dcca716

…ol/barretenberg#544)" This reverts commit 9cf96aa.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Modify bb.js to be compatible with next.js#544

feat: Modify bb.js to be compatible with next.js#544
kobyhallx merged 92 commits into
masterfrom
jb/bbjs-cra

jonybur commented Jun 18, 2023 •

edited

Loading

Uh oh!

kevaundray commented Jun 19, 2023

Uh oh!

kevaundray commented Jun 19, 2023

Uh oh!

phated Jul 20, 2023

Uh oh!

ludamad commented Jul 21, 2023

Uh oh!

kobyhallx left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jonybur commented Jun 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

kevaundray commented Jun 19, 2023

Uh oh!

kevaundray commented Jun 19, 2023

Uh oh!

phated Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

ludamad commented Jul 21, 2023

Uh oh!

kobyhallx left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jonybur commented Jun 18, 2023 •

edited

Loading