feat: Add new ops, change curve, make const, document.#568
Merged
Conversation
Rumata888
reviewed
Jun 30, 2023
| }; | ||
|
|
||
| /** | ||
| * @brief Used to construct executation trace representations of elliptic curve operations. |
ledwards2225
pushed a commit
that referenced
this pull request
Jul 17, 2023
ledwards2225
pushed a commit
that referenced
this pull request
Jul 18, 2023
ledwards2225
pushed a commit
that referenced
this pull request
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ECCOpQueue used Grumpkin as short-term hack. Changed that. Added storage for the concrete instantiations of these for two different circuit builders. Made struct members
const.Checklist:
@briefdescribing the intended functionality.includedirectives have been added.