Skip to content

feat: Add new ops, change curve, make const, document.#568

Merged
codygunton merged 4 commits into
goblin-valenciafrom
cg/vlc-more-ops-and-change-curve
Jun 30, 2023
Merged

feat: Add new ops, change curve, make const, document.#568
codygunton merged 4 commits into
goblin-valenciafrom
cg/vlc-more-ops-and-change-curve

Conversation

@codygunton

Copy link
Copy Markdown

Description

ECCOpQueue used Grumpkin as short-term hack. Changed that. Added storage for the concrete instantiations of these for two different circuit builders. Made struct members const.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@codygunton codygunton changed the title Add new ops, change curve, make const, document. feat: Add new ops, change curve, make const, document. Jun 30, 2023
};

/**
* @brief Used to construct executation trace representations of elliptic curve operations.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "executation"

@codygunton codygunton merged commit 79dd2cb into goblin-valencia Jun 30, 2023
@codygunton codygunton deleted the cg/vlc-more-ops-and-change-curve branch June 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants