Skip to content

chore: Minor increase in Pedersen generators for HIGH#619

Merged
suyash67 merged 1 commit into
masterfrom
sb/increase-ped-gen
Jul 20, 2023
Merged

chore: Minor increase in Pedersen generators for HIGH#619
suyash67 merged 1 commit into
masterfrom
sb/increase-ped-gen

Conversation

@suyash67

@suyash67 suyash67 commented Jul 19, 2023

Copy link
Copy Markdown

Description

We need 48 generators for hashing in a3 instead of the current 44, for HIGH hash indices (i.e. hash_index ≥ 40).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@suyash67 suyash67 changed the title Minor increase in Pedersen generators for HIGH chore: Minor increase in Pedersen generators for HIGH Jul 19, 2023

@ludamad ludamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me pending no impact on Noir

@ludamad ludamad added the noir-ci Run the Noir CI label Jul 19, 2023
@suyash67

Copy link
Copy Markdown
Author

noir-ci is breaking on increasing the total Pedersen generators even slightly (from 776 to 792). This was the case even we reduced the total number of generators from ~2000 to 776 (PR #413). So I am merging this one to unblock pending nullifier work on packages.

@suyash67 suyash67 merged commit af91bc8 into master Jul 20, 2023
@suyash67 suyash67 deleted the sb/increase-ped-gen branch July 20, 2023 07:40
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noir-ci Run the Noir CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants