Skip to content

fix: bb.js cli tests#695

Closed
kobyhallx wants to merge 1 commit into
masterfrom
kh-fix-js-cli-test
Closed

fix: bb.js cli tests#695
kobyhallx wants to merge 1 commit into
masterfrom
kh-fix-js-cli-test

Conversation

@kobyhallx

Copy link
Copy Markdown

Description

Fixes testing for bb.js clie

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad

ludamad commented Aug 18, 2023

Copy link
Copy Markdown
Collaborator

Note this will need to be migrated to Aztec packages with the script and merged there. We allow admin bypass for this repo but hope to only use that for release please (and nothing going forward once Aztec has release please)

@TomAFrench

Copy link
Copy Markdown
Member

Closing in favour of AztecProtocol/aztec-packages#1694

@TomAFrench TomAFrench closed this Aug 21, 2023
@ludamad ludamad deleted the kh-fix-js-cli-test branch February 20, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants