Defi bridge project (Pipeline trigger)#90
Closed
dbanks12 wants to merge 13 commits into
Closed
Conversation
* Updated bootstrap now that bberg may be a submodule, and now that cpp subdir exists * fix gitignore, wasnt properly ignoring cpp/build* * fix the barretenberg cpp formatting pre-commit hook now that barretenberg iss its own repo and may be a submodule
This reverts commit 68aff9c.
This reverts commit 3eee2fd.
* Elide sig check on 'merge' join-split proofs * README.md: Mention bootstrap.sh directory * join_split: simplify from feedback * Update join_split_circuit.cpp * Update join_split_circuit.cpp * constants.hpp: redo vk hashes Co-authored-by: ludamad <adam@aztecprotocol.com>
* fix(join_split): Check account flag. Fixes #66 * fix(constants): redo verification keys Co-authored-by: ludamad <adam@aztecprotocol.com>
* cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from PR #2