Skip to content

Improve Code Documentation Clarity and Fix Typos#72

Open
savvar9991 wants to merge 1 commit into
AztecProtocol:avmfrom
savvar9991:correct
Open

Improve Code Documentation Clarity and Fix Typos#72
savvar9991 wants to merge 1 commit into
AztecProtocol:avmfrom
savvar9991:correct

Conversation

@savvar9991

Copy link
Copy Markdown

Line 4: Changed spelling

  • Most if this is heavily inspired by zkASM / PIL of the polygon/hermez team.
  • Most of this is heavily inspired by zkASM / PIL of the polygon/hermez team.

Fixed typo: "if" -> "of"

Line 28: Changed terminology

  • This could also help to combine two lookps into one.
  • This could also help to combine two lookups into one.

Fixed typo: "lookps" -> "lookups"

Line 62: Improved clarity

  • because onyl one value of 'C' is valid for each '0'-'A'-'B'-combination.
  • because only one value of 'C' is valid for each '0'-'A'-'B'-combination.

Fixed typo: "onyl" -> "only"

Line 106: Fixed terminology

  • Similarly, in (2), users should also show when the combintation of lookups have
  • Similarly, in (2), users should also show when the combination of lookups have

Fixed typo: "combintation" -> "combination"

Line 152: Improved clarity and grammar

  • (be it because the are just duplicated or because they are already implied by lookups).
  • (be it because they are just duplicated or because they are already implied by lookups).

Fixed grammar: "the" -> "they"

@savvar9991

Copy link
Copy Markdown
Author

@Maddiaa0 Sorry for pinging, but could you please take a look at this PR when you have a moment? It's been open for 31 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant