Cross link of the CAIRA repository (#327)#349
Conversation
* Cross linked the CAIRA repository * Bump the terraform-provider versions (#347) * chore(deps): bump the terraform-providers group across 2 directories with 2 updates Bumps the terraform-providers group with 2 updates in the /infra directory: [hashicorp/azurerm](https://github.com/hashicorp/terraform-provider-azurerm) and [microsoft/power-platform](https://github.com/microsoft/terraform-provider-power-platform). Bumps the terraform-providers group with 2 updates in the /infra/modules/copilot_studio directory: [hashicorp/azurerm](https://github.com/hashicorp/terraform-provider-azurerm) and [microsoft/power-platform](https://github.com/microsoft/terraform-provider-power-platform). Updates `hashicorp/azurerm` from 4.55.0 to 4.56.0 - [Release notes](https://github.com/hashicorp/terraform-provider-azurerm/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-azurerm/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-azurerm@v4.55.0...v4.56.0) Updates `microsoft/power-platform` from 3.9.1 to 4.0.0 - [Release notes](https://github.com/microsoft/terraform-provider-power-platform/releases) - [Changelog](https://github.com/microsoft/terraform-provider-power-platform/blob/main/CHANGELOG.md) - [Commits](microsoft/terraform-provider-power-platform@v3.9.1...v4.0.0) Updates `hashicorp/azurerm` from 4.55.0 to 4.56.0 - [Release notes](https://github.com/hashicorp/terraform-provider-azurerm/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-azurerm/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-azurerm@v4.55.0...v4.56.0) Updates `microsoft/power-platform` from 3.9.1 to 4.0.0 - [Release notes](https://github.com/microsoft/terraform-provider-power-platform/releases) - [Changelog](https://github.com/microsoft/terraform-provider-power-platform/blob/main/CHANGELOG.md) - [Commits](microsoft/terraform-provider-power-platform@v3.9.1...v4.0.0) Updates `hashicorp/azurerm` from 4.55.0 to 4.56.0 - [Release notes](https://github.com/hashicorp/terraform-provider-azurerm/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-azurerm/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-azurerm@v4.55.0...v4.56.0) Updates `microsoft/power-platform` from 3.9.1 to 4.0.0 - [Release notes](https://github.com/microsoft/terraform-provider-power-platform/releases) - [Changelog](https://github.com/microsoft/terraform-provider-power-platform/blob/main/CHANGELOG.md) - [Commits](microsoft/terraform-provider-power-platform@v3.9.1...v4.0.0) Updates `hashicorp/azurerm` from 4.55.0 to 4.56.0 - [Release notes](https://github.com/hashicorp/terraform-provider-azurerm/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-azurerm/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-azurerm@v4.55.0...v4.56.0) Updates `microsoft/power-platform` from 3.9.1 to 4.0.0 - [Release notes](https://github.com/microsoft/terraform-provider-power-platform/releases) - [Changelog](https://github.com/microsoft/terraform-provider-power-platform/blob/main/CHANGELOG.md) - [Commits](microsoft/terraform-provider-power-platform@v3.9.1...v4.0.0) --- updated-dependencies: - dependency-name: hashicorp/azurerm dependency-version: 4.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: terraform-providers - dependency-name: microsoft/power-platform dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: terraform-providers - dependency-name: hashicorp/azurerm dependency-version: 4.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: terraform-providers - dependency-name: microsoft/power-platform dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: terraform-providers - dependency-name: hashicorp/azurerm dependency-version: 4.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: terraform-providers - dependency-name: microsoft/power-platform dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: terraform-providers - dependency-name: hashicorp/azurerm dependency-version: 4.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: terraform-providers - dependency-name: microsoft/power-platform dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: terraform-providers ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): remove no longer supported "maker onboarding" related variables from power platform managed environment as platform provider version upgrade to v4.0.0 * readd missing description for power_platform_managed_environment variable --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hadwa Gaber <hadwa.gaber@hotmail.com> * chore(ci): update paths-ignore for main and pull_request triggers in azure-dev.yml (#348) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristen DeVore <66267858+devorekristen@users.noreply.github.com> Co-authored-by: Ian Jensen <94021216+ianjensenisme@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hadwa Gaber <hadwa.gaber@hotmail.com>
There was a problem hiding this comment.
Pull request overview
This PR combines documentation improvements with infrastructure updates by adding cross-references to the CAIRA (Composable AI Reference Architectures) suite, upgrading Terraform provider versions, and removing deprecated Power Platform maker onboarding configuration fields.
Key changes include:
- Added CAIRA Assets section in README.md with a comparison table linking to related Microsoft acceleration assets
- Updated azurerm provider from 4.55.0 to 4.56.0 and power-platform provider from 3.9.1 to 4.0.0 (major version)
- Removed
maker_onboarding_markdownandmaker_onboarding_urlfields that are no longer supported in power-platform provider v4.0.0 - Added paths-ignore filters to CI workflow to skip builds for documentation-only changes
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Added CAIRA Assets section with comparison table cross-linking to the main CAIRA repository and describing this repository's role in the suite |
| infra/provider.tf | Updated azurerm provider to 4.56.0 and power-platform provider to 4.0.0 |
| infra/variables.tf | Removed deprecated maker_onboarding_markdown and maker_onboarding_url fields from power_platform_managed_environment variable |
| infra/modules/copilot_studio/terraform.tf | Updated azurerm provider to 4.56.0 and power-platform provider to 4.0.0 |
| infra/modules/copilot_studio/variables.tf | Removed deprecated maker onboarding fields and their descriptions from power_platform_managed_environment variable |
| infra/modules/copilot_studio/power_platform_core.tf | Removed references to maker_onboarding_markdown and maker_onboarding_url from managed environment resource |
| .github/workflows/azure-dev.yml | Added paths-ignore filters for docs, decision-log, cicd directories and markdown files to both push and pull_request triggers |
Comments suppressed due to low confidence (1)
infra/modules/copilot_studio/terraform.tf:25
- There's version inconsistency between the root module (infra/provider.tf) and the copilot_studio module. The root module uses "
> 0.3.2" for the modtm provider while this module uses "0.3.5". Additionally, the random provider uses "3.7.2" here but "> 3.7.2" in the root module. For maintainability, provider versions should be consistent across the root module and all child modules to avoid dependency conflicts.
modtm = {
source = "Azure/modtm"
version = "0.3.5"
}
powerplatform = {
source = "microsoft/power-platform"
version = "4.0.0"
}
random = {
source = "hashicorp/random"
version = "3.7.2"
|
@copilot rereview |
|
@HadwaAbdelhalem I've opened a new pull request, #350, to work on those changes. Once the pull request is ready, I'll request review from you. |
This PR description includes a bunch of things that don't happen in this PR, but the actual content LGTM. |
Cross linked the CAIRA repository
Bump the terraform-provider versions (Bump the terraform-provider versions #347)
chore(deps): bump the terraform-providers group across 2 directories with 2 updates
Bumps the terraform-providers group with 2 updates in the /infra directory: hashicorp/azurerm and microsoft/power-platform.
Bumps the terraform-providers group with 2 updates in the /infra/modules/copilot_studio directory: hashicorp/azurerm and microsoft/power-platform.
Updates
hashicorp/azurermfrom 4.55.0 to 4.56.0Updates
microsoft/power-platformfrom 3.9.1 to 4.0.0Updates
hashicorp/azurermfrom 4.55.0 to 4.56.0Updates
microsoft/power-platformfrom 3.9.1 to 4.0.0Updates
hashicorp/azurermfrom 4.55.0 to 4.56.0Updates
microsoft/power-platformfrom 3.9.1 to 4.0.0Updates
hashicorp/azurermfrom 4.55.0 to 4.56.0Updates
microsoft/power-platformfrom 3.9.1 to 4.0.0updated-dependencies:
chore(deps): remove no longer supported "maker onboarding" related variables from power platform managed environment as platform provider version upgrade to v4.0.0
readd missing description for power_platform_managed_environment variable
Description
Please include a summary of the changes.
Related Issue(s)
Link to the issue(s) this PR is related to. Prefix with "Fixes" or "Resolves". Every PR must be associated with an Issue
Example: Resolves #1234