Skip to content

Add Quickstart for NetworkTraversal for JS#31

Merged
chriswhilar merged 4 commits intoAzure-Samples:mainfrom
AriZavala2:main
Nov 29, 2021
Merged

Add Quickstart for NetworkTraversal for JS#31
chriswhilar merged 4 commits intoAzure-Samples:mainfrom
AriZavala2:main

Conversation

@AriZavala2
Copy link
Copy Markdown
Contributor

Purpose

  • Add Quickstart for NetworkTraversal for JS

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: Sample

## How to Test
*  Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install


* Test the code
<!-- Add steps to run the tests suite and/or manually test -->

## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->

@ajpeacock0
Copy link
Copy Markdown

I don't think we need the files in a javascript directory under network-traversal-quickstart/javascript since this entire repo is js. Also looking at the existing examples, it looks like the directory name relates to the scenario, so something like network-traversal-get-relay-config

Comment thread network-traversal-quickstart/javascript/getRelayConfiguration.js Outdated
Comment thread network-traversal-quickstart/javascript/sample.env Outdated
Comment thread network-traversal-quickstart/javascript/package.json Outdated
Comment thread network-traversal-quickstart/javascript/README.md Outdated
Comment thread network-traversal-get-relay-config/getRelayConfigurationWithIdentity.js Outdated
@chriswhilar chriswhilar self-requested a review November 29, 2021 16:10
@chriswhilar chriswhilar merged commit c509066 into Azure-Samples:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants