Skip to content
This repository was archived by the owner on Oct 12, 2023. It is now read-only.

Minor bug in KeyVaultADALAuthenticator.java#6

Open
halilayyildiz wants to merge 1 commit into
Azure-Samples:masterfrom
halilayyildiz:patch-1
Open

Minor bug in KeyVaultADALAuthenticator.java#6
halilayyildiz wants to merge 1 commit into
Azure-Samples:masterfrom
halilayyildiz:patch-1

Conversation

@halilayyildiz

Copy link
Copy Markdown

Don't check clientKey twice, instead do null check for clientId

Purpose

Fixes simple copy paste bug

  • ...

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Don't check clientKey twice, instead do null check for clientId
@halilayyildiz halilayyildiz changed the title Update KeyVaultADALAuthenticator.java Minor bug in KeyVaultADALAuthenticator.java Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant