Skip to content

feat: oras pull pause image if not cached for windows network isolated cluster #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fseldow wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: oras pull pause image if not cached for windows network isolated cluster #8038

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab48a56
feat: oras pull pause image if not cached for windows network isolate…
fseldow Mar 8, 2026
70b0ae2
Update staging/cse/windows/containerdfunc.ps1
fseldow Mar 9, 2026
83a3619
Update staging/cse/windows/networkisolatedclusterfunc.ps1
fseldow Mar 9, 2026
1c2e7af
fix ut
fseldow Mar 9, 2026
b3cbbee
fix ut
fseldow Mar 9, 2026
3b19e61
2
fseldow Mar 9, 2026
c335505
3
fseldow Mar 9, 2026
c82af8f
4
fseldow Mar 9, 2026
6f2fa53
5
fseldow Mar 9, 2026
61e61b1
f
fseldow Mar 9, 2026
74c13b0
6
fseldow Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update staging/cse/windows/containerdfunc.ps1 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
  • Loading branch information
@fseldow
fseldow and Copilot committed Mar 9, 2026
commit 70b0ae2cfc4a3525442dcdde8df1b329400541a3
13 changes: 9 additions & 4 deletions staging/cse/windows/containerdfunc.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,16 @@ function Install-Containerd {

RegisterContainerDService -KubeDir $KubeDir
if ((Test-Path variable:global:BootstrapProfileContainerRegistryServer) -and -not [string]::IsNullOrEmpty($global:BootstrapProfileContainerRegistryServer)) {
Copy link
Contributor

@timmy-wright timmy-wright Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the is null or empty first so that we don't test the path if the string is empty.

try {
Set-PodInfraContainerImage
if (Get-Command -Name Set-PodInfraContainerImage -ErrorAction SilentlyContinue) {
try {
Set-PodInfraContainerImage
}
catch {
Set-ExitCode -ExitCode $global:WINDOWS_CSE_ERROR_ORAS_PULL_POD_INFRA_CONTAINER -ErrorMessage "Failed to set pod infra container image: $_"
}
}
catch {
Set-ExitCode -ExitCode $global:WINDOWS_CSE_ERROR_ORAS_PULL_POD_INFRA_CONTAINER -ErrorMessage "Failed to set pod infra container image: $_"
else {
Write-Log "Set-PodInfraContainerImage command not found; skipping pod infra container image configuration."
}
}
Enable-Logging
Expand Down