-
Notifications
You must be signed in to change notification settings - Fork 250
fix: disable nvidia-fabricmanager on single-GPU VMs with MIG #8049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ganeshkumarashok
wants to merge
4
commits into
main
Choose a base branch
from
aganeshkumar/fix-fabric-manager-mig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
84e6850
fix: disable nvidia-fabricmanager on single-GPU VMs with MIG
ganeshkumarashok 177c379
fix: use list-unit-files and reset-failed for fabric manager
ganeshkumarashok c061120
fix: address copilot feedback - use systemctl helpers
ganeshkumarashok d316c73
fix: use --no-legend and grep for robust unit file detection
ganeshkumarashok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
systemctl list-unit-files ... >/dev/nullguard may not reliably indicate that the unit exists (the command can exit 0 even when no unit files match), which can causesystemctl_stop/systemctl_disableto run and potentially spend a long time retrying on nodes wherenvidia-fabricmanagerisn’t installed. Consider making the guard check for an actual match in the command output (e.g., using--no-legendandgrep -qfor the unit name) or using an existence check that fails when the unit file is absent, before invoking the retrying wrappers.