chore: use renovate for waagent version, write to release notes, add log-checking e2e#8062
Open
chore: use renovate for waagent version, write to release notes, add log-checking e2e#8062
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves WALinuxAgent (waagent) version tracking into parts/common/components.json (so Renovate can update it), logs the installed waagent version into the VHD release notes, and adds an e2e validator that inspects /var/log/waagent.log to confirm expected behavior/version.
Changes:
- Add a
walinuxagentpackage entry toparts/common/components.jsonand configure Renovate to updategithub-releases=tags. - Update the post-deprovision waagent install flow to read the target version from
components.json, pass it into the installer, and append it tovhd-install.complete. - Add a new e2e validator (
ValidateWaagentLog) and wire it into the common Linux validation flow.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vhdbuilder/packer/test/linux-vhd-content-test.sh |
Updates test commentary around waagent installation expectations. |
vhdbuilder/packer/post-deprovision-walinuxagent.sh |
Reads waagent version from /opt/azure/components.json, passes it to the installer, and logs to VHD release notes. |
vhdbuilder/packer/install_walinuxagent.py |
Changes installer to accept an explicit version argument (from components.json) instead of deriving version from GAFamily. |
parts/common/components.json |
Adds walinuxagent entry with Renovate tag targeting GitHub releases. |
e2e/validators.go |
Adds ValidateWaagentLog validator that checks waagent logs for expected behavior/version. |
e2e/validation.go |
Runs ValidateWaagentLog as part of ValidateCommonLinux. |
.github/renovate.json |
Adds a custom Renovate regex manager for github-releases= renovateTag entries in components.json. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #