Use correct time columns to check Expiration and to summarize in TI Map Detections.#3549
Closed
ep3p wants to merge 5 commits into
Closed
Use correct time columns to check Expiration and to summarize in TI Map Detections.#3549ep3p wants to merge 5 commits into
ep3p wants to merge 5 commits into
Conversation
ep3p
requested review from
Amitbergman,
NoamLandress,
Yaniv-Shasha,
YaronFruchtmann,
YuvalNaor,
aprakash13,
ashwin-patil,
dicolanl,
ianhelle,
juliango2100,
laithhisham,
liatlishams,
liemilyg,
lior-tamir,
mgladi,
nazang,
oshezaf,
oshvartz,
petebryan,
preetikr,
sagamzu,
sarah-yo,
shainw,
shschwar,
sreedharande and
timbMSFT
as code owners
Use project-rename instead of extend for columns that conflict with Indicator columns.
Contributor
|
As I said in other comments, we are using this PR with multiple changes across all TI - #3571. Thanks much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request comes from a closed unmerged pull request that got messy (#3477)
Fixes #
Saving some unnecessary conditions.
Expiration Date is already getting compared at
2nd summarize was getting its TimeGenerated from the event table, not from the Indicator Table.
Proposed Changes