Match TimeStamp and Etag precision and value#1661
Merged
XiaoningLiu merged 24 commits intoAzure:mainfrom Sep 8, 2022
Merged
Conversation
Comment on lines
+901
to
+905
| headers.etag | ||
| .replace("W/\"datetime'", "") | ||
| .replace("'\"", "") | ||
| .replace("%3A", ":") | ||
| .replace("%3A", ":"), |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Comment on lines
+901
to
+904
| headers.etag | ||
| .replace("W/\"datetime'", "") | ||
| .replace("'\"", "") | ||
| .replace("%3A", ":") |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Collaborator
Author
|
azp /run |
IMeeus
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Please get this fix through. Since the logic app (standard) vs code extension update of 30/08, azurite 3.16 doesn't work anymore either, because service api-version 2021-06-08 has been forced. This means that running logic apps locally is impossible for the moment, unless you use azure storage instead of azurite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues running Logic Apps locally with Azurite.
Ensures that Table API Entities use same hrtime source value for both Etag and TimeStamp.
Adds Test.
Fixes #1653 #1475