Skip to content

Match TimeStamp and Etag precision and value#1661

Merged
XiaoningLiu merged 24 commits intoAzure:mainfrom
edwin-huber:azurite_issue_1653
Sep 8, 2022
Merged

Match TimeStamp and Etag precision and value#1661
XiaoningLiu merged 24 commits intoAzure:mainfrom
edwin-huber:azurite_issue_1653

Conversation

@edwin-huber
Copy link
Collaborator

Resolves issues running Logic Apps locally with Azurite.
Ensures that Table API Entities use same hrtime source value for both Etag and TimeStamp.
Adds Test.
Fixes #1653 #1475

@edwin-huber edwin-huber added table-storage Relating to Azurite table storage implementation service-parity Parity with Azure service behavior labels Sep 2, 2022
Comment on lines +901 to +905
headers.etag
.replace("W/\"datetime'", "")
.replace("'\"", "")
.replace("%3A", ":")
.replace("%3A", ":"),

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of "%3A".
Comment on lines +901 to +904
headers.etag
.replace("W/\"datetime'", "")
.replace("'\"", "")
.replace("%3A", ":")

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of "%3A".
@edwin-huber
Copy link
Collaborator Author

azp /run

Copy link

@IMeeus IMeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get this fix through. Since the logic app (standard) vs code extension update of 30/08, azurite 3.16 doesn't work anymore either, because service api-version 2021-06-08 has been forced. This means that running logic apps locally is impossible for the moment, unless you use azure storage instead of azurite.

@XiaoningLiu XiaoningLiu merged commit 4af54f0 into Azure:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-parity Parity with Azure service behavior table-storage Relating to Azurite table storage implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Http 412 response in Logic Apps request processing

3 participants