Skip to content

Fault injection#666

Open
ljian3377 wants to merge 8 commits intoAzure:mainfrom
ljian3377:fault-injection
Open

Fault injection#666
ljian3377 wants to merge 8 commits intoAzure:mainfrom
ljian3377:fault-injection

Conversation

@ljian3377
Copy link
Member

No description provided.

@XiaoningLiu
Copy link
Member

res.getBodyStream().write(xmlBody);

As we synced offline. We can consider introduce a callback, for example, callback in context like context.serializeInject to hijack the response stream.


Refers to: src/blob/generated/utils/serializer.ts:316 in 1c05fb2. [](commit_id = 1c05fb2, deletion_comment = False)

@ljian3377 ljian3377 marked this pull request as ready for review January 27, 2021 10:32
@XiaoningLiu
Copy link
Member

Please update Readme with examples for the injection.

return this.context.startTime;
}

public set serializerResBodyInjectCallback(
Copy link
Member

@XiaoningLiu XiaoningLiu Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please duplicate the changes to generated files for other services (table, queue) too. Same with others.
We need to keep the generated files align with all other services.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azurite uses full name.

serializerResBodyInjectCallback => serializerResponseBodyInjectCallback

@XiaoningLiu
Copy link
Member

How about injection support for other services?

@ljian3377
Copy link
Member Author

How about injection support for other services?

We can track it with another work item. Meanwhile we can wait for some feedback and duplicate it for other services when it stabilizes.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants