Set user error if there are no eligble resource to fault in target zone. - #18
Open
arpja wants to merge 8 commits into
Open
Set user error if there are no eligble resource to fault in target zone.#18arpja wants to merge 8 commits into
arpja wants to merge 8 commits into
Conversation
- moving scripts to canary folder
…kward compat Changes applied to all 7 zonal fault scripts (and their Canary mirrors): * Add [object]\ parameter accepting JSON string, Hashtable, or PSCustomObject (the last is what Azure Automation REST API produces after its single-decode of JSON parameter values). * Keep the existing [string]\ as an optional fallback. When SubscriptionToTargetZone is null/empty, TargetZone is applied uniformly to every resource (original behavior preserved). * If a subscription's value in SubscriptionToTargetZone is empty, the resource is still faulted but without zone targeting. * New Get-ResourceTargets helper resolves the target zone for each resource id (looking up its subscription in the JSON dict, or falling back to TargetZone). * Add per-resource Write-Verbose log line so the zone being targeted for each resource is visible in the runbook job stream. * Silence the chatty Az.* module-load verbose output by pre-importing Az.Accounts and the resource-specific Az module at runspace scope under \SilentlyContinue = 'SilentlyContinue', then restoring 'Continue' so our own Write-Verbose logs still appear. Verified end-to-end against AKSRunbook in Automation with both invocation styles (SubscriptionToTargetZone wins; TargetZone-only legacy compat). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d not have eligible nodes/probes to fault in the target region.
…ing is not possible since there aren’t any resources in the selected target zone.
arpja
changed the title
| $err = $null | ||
| if (-not $op.IsSuccess) { | ||
| $metadata = @{ Status = $op.Status } | ||
| if ($op.Status -eq 'Skipped') { |
Member
There was a problem hiding this comment.
I hope the skipped status is returned by the $op. Please check or confirm once.
| Write-Verbose "AKS zone fault completed with PartialSuccess. $skippedCount of $($AksTargetList.Count) cluster(s) had no eligible nodes to fault in the target zone (RHDSUserErrorAKSNoNodesToFaultInTargetZone)." | ||
| } else { | ||
| Write-Verbose "All AKS zone fault operations completed successfully." | ||
| } |
Member
There was a problem hiding this comment.
How are we handling the this skipped return at the Drills code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add skipped in job status for ineligible resources