fix(release): correct target_commitish and use v-prefixed tags - #37
Merged
Suneha Bose (bosesuneha) merged 1 commit intoJul 31, 2026
Conversation
release.yaml passed github.ref (refs/heads/main) as the branch to create_release.yaml, which prepends refs/heads/ again, producing an invalid target_commitish (refs/heads/refs/heads/main). This caused the release run to fail with 'Validation Failed: target_commitish is invalid'. Use github.ref_name (main) so the resulting commitish is refs/heads/main. Also prefix the version with 'v' in both the tag-exists check and the release version, matching the historical tag scheme (v1.0.x) and the consumer-facing release_js_project.yaml. This fixes the release tag/name (v1.1.0 instead of 1.1.0) and repairs the idempotency guard, which previously checked for a bare '1.1.0' tag that never exists.
David Gamero (davidgamero)
approved these changes
Jul 31, 2026
David Gamero (davidgamero)
left a comment
David Gamero (davidgamero)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release.yamlfails end-to-end (latest v1.1.0 run) with:Cause
release.yamlpasses the full ref asbranch, andcreate_release.yamlprependsrefs/heads/again:Fix
In
.github/workflows/release.yaml:branch: ${{ github.ref }}becomes${{ github.ref_name }}, giving a validrefs/heads/main.vin the tag-exists check and release version, producingv1.1.0to match the existingv1.0.xtags,release_js_project.yaml, and the release-proposalgit describe --match 'v*'. Also repairs the idempotency check that looked for a bare1.1.0tag.Scope
Affects only this repo's self-release. Consumers use
release_js_project.yamland are unaffected.