Skip to content

feat: uncommenting item that reflects on the document links problem#658

Merged
waelkdouh merged 14 commits into
Azure:mainfrom
felipementel:main
Dec 16, 2024
Merged

feat: uncommenting item that reflects on the document links problem#658
waelkdouh merged 14 commits into
Azure:mainfrom
felipementel:main

Conversation

@felipementel
Copy link
Copy Markdown
Contributor

I believe the issue in item #607 will be resolved with this commit.

@felipementel
Copy link
Copy Markdown
Contributor Author

Hi @waelkdouh, how are you?

Just like in my first comment on this pull request, I believe I have found the problem that is breaking the documentation links, and for that I originally created this pull request.

Today I updated the packages that need updating, and I have combined them in this same pull request.

If I think this could negatively affect the repository, I can cancel this request and create two separate ones.

I await your contact, thank you

@waelkdouh
Copy link
Copy Markdown
Contributor

Hi @felipementel could you elaborate a bit more on what you mean by it could pretend it could negatively affect this repository? I'm just trying to understand why you are suggesting creating two separate requests.

@felipementel
Copy link
Copy Markdown
Contributor Author

@waelkdouh
The reason would be the scope of the update.

There is a request for a documentation update, which refers to the problem
and another scope, which is the update of the nuget packages.

unfortunately, due to a "mistake" of mine, I combined everything in the same PR

@waelkdouh
Copy link
Copy Markdown
Contributor

Gotcha. No worries I will review and report back here accordingly. Thanks again for your contributions.

@felipementel
Copy link
Copy Markdown
Contributor Author

hello @waelkdouh
Do you have any expectations of when or if my pull request will be approved?

@waelkdouh waelkdouh merged commit 8c85e16 into Azure:main Dec 16, 2024
@waelkdouh
Copy link
Copy Markdown
Contributor

hello @waelkdouh Do you have any expectations of when or if my pull request will be approved?

Hi @felipementel apologies for the delay. I went ahead and merged the PR. Thank you for your contributions!

@felipementel
Copy link
Copy Markdown
Contributor Author

@waelkdouh

I tested and all links are ok now

image

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants