Pass GitHub SHA to publisher#780
Conversation
Output GitHub Sha
|
@wagnerb3 isn't the suggestion by martin2176 which was mentioned in the issue here #696 (comment) the correct solution? |
|
@wagnerb3 based on martin's suggestion it would look like this: get-commit: |
|
@waelkdouh, I concur that's what it should look like. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the GitHub workflow configuration by fixing the commit ID handling and correcting a spelling error. The changes ensure proper access to the GitHub SHA value using the correct syntax.
- Replace environment variable syntax with proper GitHub Actions context syntax for accessing SHA
- Simplify output definition by directly using the GitHub context
- Fix spelling error in comment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
waelkdouh
left a comment
There was a problem hiding this comment.
get-commit:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4 - name: Set the Commit Id
id: commit
run: echo "commit_id=${GITHUB_SHA}" >> $GITHUB_OUTPUT
outputs:
commit_id: ${{ steps.commit.outputs.commit_id }}
|
@wagnerb3 thank you for your contributions. Merging now. |
Address #696