Skip to content

Pass GitHub SHA to publisher#780

Merged
waelkdouh merged 4 commits into
Azure:mainfrom
wagnerb3:main
Aug 21, 2025
Merged

Pass GitHub SHA to publisher#780
waelkdouh merged 4 commits into
Azure:mainfrom
wagnerb3:main

Conversation

@wagnerb3
Copy link
Copy Markdown
Contributor

Address #696

@waelkdouh
Copy link
Copy Markdown
Contributor

@wagnerb3 isn't the suggestion by martin2176 which was mentioned in the issue here #696 (comment) the correct solution?

@waelkdouh
Copy link
Copy Markdown
Contributor

@wagnerb3 based on martin's suggestion it would look like this:

get-commit:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set the Commit Id
id: commit
run: echo "commit_id=${GITHUB_SHA}" >> $GITHUB_OUTPUT
outputs:
commit_id: ${{ steps.commit.outputs.commit_id }}

@anotherRedbeard
Copy link
Copy Markdown
Contributor

@waelkdouh, I concur that's what it should look like.

@waelkdouh waelkdouh requested a review from Copilot August 21, 2025 21:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the GitHub workflow configuration by fixing the commit ID handling and correcting a spelling error. The changes ensure proper access to the GitHub SHA value using the correct syntax.

  • Replace environment variable syntax with proper GitHub Actions context syntax for accessing SHA
  • Simplify output definition by directly using the GitHub context
  • Fix spelling error in comment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tools/github_workflows/run-publisher.yaml
Copy link
Copy Markdown
Contributor

@waelkdouh waelkdouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get-commit:
runs-on: ubuntu-latest
steps:

  • name: Checkout repository
    uses: actions/checkout@v4
  • name: Set the Commit Id
    id: commit
    run: echo "commit_id=${GITHUB_SHA}" >> $GITHUB_OUTPUT
    outputs:
    commit_id: ${{ steps.commit.outputs.commit_id }}

@wagnerb3 wagnerb3 requested a review from waelkdouh August 21, 2025 22:01
Copy link
Copy Markdown
Contributor

@waelkdouh waelkdouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@waelkdouh
Copy link
Copy Markdown
Contributor

@wagnerb3 thank you for your contributions. Merging now.

@waelkdouh waelkdouh merged commit 89d194d into Azure:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants