This repository was archived by the owner on Jun 16, 2026. It is now read-only.
Mitigate breaking change for optional parameter change#3686
Merged
Conversation
archerzz
reviewed
Aug 24, 2023
Member
Author
|
@m-nash Please take a look at this PR, it mitigates breaking changes for additional optional parameters in model factory. |
live1206
commented
Dec 5, 2023
live1206
commented
Dec 5, 2023
ArcturusZhang
approved these changes
Dec 7, 2023
ArthurMa1978
approved these changes
Dec 7, 2023
6 tasks
live1206
added a commit
that referenced
this pull request
Dec 8, 2023
live1206
added a commit
to live1206/autorest.csharp
that referenced
this pull request
Dec 8, 2023
…e#3686)" (Azure#4023) This reverts commit eee12d7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3596.
This PR introduces
SignatureType, it holds three portions of code:current union customcompare withprevious contractoutputs the changeset, with it we can apply different rules withIt provides