This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Support HttpMethod OPTIONS#1231
Merged
Merged
Conversation
alzimmermsft
requested review from
srnagar and
weidongxu-microsoft
as code owners
October 25, 2021 17:54
Member
Author
That is correct. When I first made the PR I thought the only missing part in |
weidongxu-microsoft
approved these changes
Nov 8, 2021
weidongxu-microsoft
left a comment
weidongxu-microsoft
left a comment
Member
There was a problem hiding this comment.
I am updating core to 1.22.0 in PR #1247
alzimmermsft
requested review from
XiaofeiCao and
haolingdong-msft
as code owners
November 12, 2021 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #453
This PR adds support for
HttpMethod.OPTIONSin code generation. Fixed by removing guard against the an HTTP method options as the generator has been updated to a version ofazure-corewhich containsOPTIONSas a enum value inHttpMethod.