This repository was archived by the owner on Jul 6, 2026. It is now read-only.
mgmt, make discriminator setter protected#2624
Merged
XiaofeiCao merged 4 commits intoMar 15, 2024
Merged
Conversation
weidongxu-microsoft
approved these changes
Mar 14, 2024
XiaofeiCao
commented
Mar 14, 2024
Comment on lines
+132
to
+133
| # polymorphic models in different packages | ||
| "--version=$AUTOREST_CORE_VERSION $FLUENTLITE_ARGUMENTS --regenerate-pom=false --input-file=https://github.com/Azure/azure-rest-api-specs/blob/64337ca106a20055b389f9652ea8cf942aa94252/specification/consumption/resource-manager/Microsoft.Consumption/stable/2023-11-01/consumption.json --java.namespace=com.azure.mgmtlitetest.consumption" | ||
| "--version=$AUTOREST_CORE_VERSION $FLUENTLITE_ARGUMENTS --regenerate-pom=false --input-file=https://github.com/Azure/azure-rest-api-specs/blob/64337ca106a20055b389f9652ea8cf942aa94252/specification/consumption/resource-manager/Microsoft.Consumption/stable/2023-11-01/consumption.json --java.namespace=com.azure.mgmtlitetest.consumption --generate-tests=false" |
Contributor
Author
There was a problem hiding this comment.
Model mock test seems having trouble identifying the right child class:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=3595400&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=738c417a-4a48-5620-b571-4f9e77e0bfd2&l=3290
@org.junit.jupiter.api.Test
public void testDeserialize() throws Exception {
ModernReservationRecommendation model = BinaryData.fromString(
"{\"kind\":\"legacy\",\"properties\":{\"scope\":\"uewmrswnjlxuzrhw\",\"location\":\"sxjb\",\"lookBackPeriod\":1129684980,\"instanceFlexibilityRatio\":40.48269,\"instanceFlexibilityGroup\":\"dohzjq\",\"normalizedSize\":\"ucoig\",\"recommendedQuantityNormalized\":38.62258,\"meterId\":\"2668484c-c47e-440c-9b15-69e796f1b9db\",\"term\":\"nwfepbnwg\",\"costWithNoReservedInstances\":{\"currency\":\"jgcgbjbgdlfgtdys\"},\"resourceType\":\"flq\",\"totalCostWithReservedInstances\":{\"currency\":\"q\"},\"netSavings\":{\"currency\":\"jrwdkqz\"},\"firstUsageDate\":\"2021-01-23T02:59:42Z\",\"skuProperties\":[{\"name\":\"iunjxdf\",\"value\":\"ntkwcegy\"},{\"name\":\"lbnseqac\",\"value\":\"vpilg\"},{\"name\":\"oq\",\"value\":\"gmditgueiookjbs\"},{\"name\":\"rtdtpdelq\",\"value\":\"slmot\"}],\"skuName\":\"bnfxofvc\"},\"etag\":\"irazftxejwabmd\",\"tags\":{\"kyqltqsrogt\":\"mvcopexcmjurbuhh\",\"ysidfvclgl\":\"wkffdjkt\"},\"location\":\"fuijtkbus\",\"sku\":\"gsfikayiansha\",\"id\":\"ujtjiqxfz\",\"name\":\"j\",\"type\":\"ttvwkpqh\"}")
.toObject(ModernReservationRecommendation.class);
}Disabling generated mock test.
alzimmermsft
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2574
For discriminator setters, we make them protected in case super class and child classes are in different packages.
code: 3849ab0
test: 0365751