This repository was archived by the owner on Jul 6, 2026. It is now read-only.
tsp, fix wire name on header/query/path#2848
Merged
weidongxu-microsoft merged 7 commits intoJul 3, 2024
Merged
Conversation
weidongxu-microsoft
requested review from
XiaofeiCao,
haolingdong-msft and
srnagar
as code owners
XiaofeiCao
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emitter mainly uses "wire name" for mapping of ModelProperty (the only exception is the request "body").
Currently TCGC
getWireNameseems only work for JSON property.Add branch for path/query/header parameter.
The bug likely won't affect existing lib, as it only happens in "alias/spread" + "non-body-property in that alias/spread".
But after "spread is spread", one test case is affected. Ref #2821