You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cleans up a lot of code in StreamSerializationModelTemplate by using an instance class to generate code. This removes the need to pass many parameters all over the place.
There is also a fix to generating fields in ModelTemplate by having the overload of getFieldProperties check if fromJsonShared can be used to determine whether the subclass should shade fields of a super class. The only time shading shouldn't happen with polymorphic types is when fromJsonShared can be used as those properties will be deserialized by the super type's fromJsonShared method, meaning the subtype doesn't need to shade.
Hi @alzimmermsft, I merged your pr with main branch to a feature branch, and tried to regenerate for TypeSpec SDKs based on the branch. I found API view diff like below, @override is removed from getKind() in subclass. I suppose after setting share-jsonserializable-code to false, there shoud be no diff. It seems a bug. Could u please check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up a lot of code in
StreamSerializationModelTemplateby using an instance class to generate code. This removes the need to pass many parameters all over the place.There is also a fix to generating fields in
ModelTemplateby having the overload ofgetFieldPropertiescheck iffromJsonSharedcan be used to determine whether the subclass should shade fields of a super class. The only time shading shouldn't happen with polymorphic types is whenfromJsonSharedcan be used as those properties will be deserialized by the super type'sfromJsonSharedmethod, meaning the subtype doesn't need to shade.