Bump check to 37

autorest/codegen/models/client.py

@@ -99,6 +99,6 @@ def imports_for_multiapi(self, async_mode: bool) -> FileImport:
             pass
         return file_import
 
-    def send_request_signature(self, async_mode: bool, is_python3_file: bool) -> List[str]:
-        request_signature = ["request: HttpRequest," if async_mode else "request,  # type: HttpRequest"]
+    def send_request_signature(self, is_python3_file: bool) -> List[str]:
+        request_signature = ["request: HttpRequest," if is_python3_file else "request,  # type: HttpRequest"]
         return request_signature + self.parameters.method_signature_kwargs(is_python3_file)

autorest/codegen/serializers/client_serializer.py

@@ -116,7 +116,7 @@ def _send_request_signature(self, async_mode: bool) -> str:
             method_name=self.code_model.send_request_name,
             is_in_class=True,
             method_param_signatures=self.code_model.service_client.send_request_signature(
-                async_mode, async_mode or self.is_python3_file
+                async_mode or self.is_python3_file
             ),
         )
 

eng/pipelines/ci.yml

@@ -10,7 +10,7 @@ pr:
 
 variables:
   NodeVersion: "12.x"
-  PythonVersion: "3.6"
+  PythonVersion: "3.7"
   TestFolder: "$(Build.SourcesDirectory)/test/"
   AUTOREST_TESTSERVER_COVERAGE_DIRECTORY: "$(Build.SourcesDirectory)/coverage/"
 
@@ -31,10 +31,10 @@ jobs:
           OSName: "Linux"
           OSVmImage: "MMSUbuntu20.04"
           PythonVersion: "2.7"
-        Linux_Python36:
+        Linux_Python37:
           OSName: "Linux"
           OSVmImage: "MMSUbuntu20.04"
-          PythonVersion: "3.6"
+          PythonVersion: "3.7"
           CoverageArg: ""
         Linux_Python310:
           OSName: "Linux"
@@ -52,9 +52,9 @@ jobs:
           versionSpec: "$(NodeVersion)"
 
       - task: UsePythonVersion@0
-        displayName: "Use Python 3.6"
+        displayName: "Use Python 3.7"
         inputs:
-          versionSpec: 3.6
+          versionSpec: 3.7
 
       - script: |
           cd $(Build.SourcesDirectory)
@@ -127,7 +127,7 @@ jobs:
           cd $(TestFolder)/azure/version-tolerant
           tox -e lint
         displayName: 'Lint version-tolerant "azure" Tests - Python $(PythonVersion)'
-        condition: and(succeededOrFailed(), eq(variables['PythonVersion'], '3.6'))
+        condition: and(succeededOrFailed(), eq(variables['PythonVersion'], '3.7'))
 
       - script: |
           cd $(TestFolder)/vanilla/legacy
@@ -168,7 +168,7 @@ jobs:
           cd $(TestFolder)/vanilla/version-tolerant
           tox -e lint
         displayName: 'Lint version-tolerant "vanilla" Tests - Python $(PythonVersion)'
-        condition: and(succeededOrFailed(), eq(variables['PythonVersion'], '3.6'))
+        condition: and(succeededOrFailed(), eq(variables['PythonVersion'], '3.7'))
 
       - script: |
           cd $(TestFolder)/llc/low-level
@@ -184,7 +184,7 @@ jobs:
           cd $(TestFolder)/llc/version-tolerant
           tox -e lint
         displayName: 'Lint version-tolerant "llc" Tests - Python $(PythonVersion)'
-        condition: and(succeededOrFailed(), eq(variables['PythonVersion'], '3.6'))
+        condition: and(succeededOrFailed(), eq(variables['PythonVersion'], '3.7'))
       - script: |
           cd $(TestFolder)/multiapi
           tox -e ci

test/azure/low-level/Expected/AcceptanceTests/AzureBodyDurationLowLevel/bodydurationlowlevel/_auto_rest_duration_test_service.py

@@ -36,11 +36,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `bodydurationlowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/AzureParameterGroupingLowLevel/azureparametergroupinglowlevel/_auto_rest_parameter_grouping_test_service.py

@@ -35,11 +35,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
         self._serialize = Serializer()
         self._deserialize = Deserializer()
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `azureparametergroupinglowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/AzureReportLowLevel/azurereportlowlevel/_auto_rest_report_service_for_azure.py

@@ -36,11 +36,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `azurereportlowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/AzureSpecialsLowLevel/azurespecialpropertieslowlevel/_auto_rest_azure_special_parameters_test_client.py

@@ -54,11 +54,7 @@ def __init__(
         self._serialize = Serializer()
         self._deserialize = Deserializer()
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `azurespecialpropertieslowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/CustomBaseUriLowLevel/custombaseurllowlevel/_auto_rest_parameterized_host_test_client.py

@@ -35,11 +35,7 @@ def __init__(self, host: str = "host", **kwargs: Any) -> None:
         self._serialize = Serializer()
         self._deserialize = Deserializer()
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `custombaseurllowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/CustomUrlPagingLowLevel/custombaseurlpaginglowlevel/_auto_rest_parameterized_host_test_paging_client.py

@@ -36,11 +36,7 @@ def __init__(self, host: str = "host", **kwargs: Any) -> None:
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `custombaseurlpaginglowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/HeadExceptionsLowLevel/headexceptionslowlevel/_auto_rest_head_exception_test_service.py

@@ -42,11 +42,7 @@ def __init__(
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `headexceptionslowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/HeadLowLevel/headlowlevel/_auto_rest_head_test_service.py

@@ -42,11 +42,7 @@ def __init__(
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `headlowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/LroLowLevel/lrolowlevel/_auto_rest_long_running_operation_test_service.py

@@ -42,11 +42,7 @@ def __init__(
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `lrolowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/LroWithParameterizedEndpointsLowLevel/lrowithparameterizedendpointslowlevel/_lro_with_paramaterized_endpoints.py

@@ -37,11 +37,7 @@ def __init__(self, host: str = "host", **kwargs: Any) -> None:
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `lrowithparameterizedendpointslowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/PagingLowLevel/paginglowlevel/_auto_rest_paging_test_service.py

@@ -36,11 +36,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `paginglowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/StorageManagementClientLowLevel/storagelowlevel/_storage_management_client.py

@@ -55,11 +55,7 @@ def __init__(
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `storagelowlevel.rest`.

test/azure/low-level/Expected/AcceptanceTests/SubscriptionIdApiVersionLowLevel/subscriptionidapiversionlowlevel/_microsoft_azure_test_url.py

@@ -54,11 +54,7 @@ def __init__(
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         We have helper methods to create requests specific to this service in `subscriptionidapiversionlowlevel.rest`.

test/azure/version-tolerant/Expected/AcceptanceTests/AzureBodyDurationVersionTolerant/bodydurationversiontolerant/_auto_rest_duration_test_service.py

@@ -40,11 +40,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
         self._serialize.client_side_validation = False
         self.duration = DurationOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/AzureParameterGroupingVersionTolerant/azureparametergroupingversiontolerant/_auto_rest_parameter_grouping_test_service.py

@@ -42,11 +42,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
             self._client, self._config, self._serialize, self._deserialize
         )
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/AzureReportVersionTolerant/azurereportversiontolerant/_auto_rest_report_service_for_azure.py

@@ -37,11 +37,7 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/AzureSpecialsVersionTolerant/azurespecialpropertiesversiontolerant/_auto_rest_azure_special_parameters_test_client.py

@@ -106,11 +106,7 @@ def __init__(
         self.odata = OdataOperations(self._client, self._config, self._serialize, self._deserialize)
         self.header = HeaderOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/CustomBaseUriVersionTolerant/custombaseurlversiontolerant/_auto_rest_parameterized_host_test_client.py

@@ -39,11 +39,7 @@ def __init__(self, host: str = "host", **kwargs: Any) -> None:
         self._deserialize = Deserializer()
         self.paths = PathsOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/CustomPollerPagerVersionTolerant/custompollerpagerversiontolerant/_auto_rest_paging_test_service.py

@@ -48,11 +48,7 @@ def __init__(
         self._serialize.client_side_validation = False
         self.paging = PagingOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/CustomUrlPagingVersionTolerant/custombaseurlpagingversiontolerant/_auto_rest_parameterized_host_test_paging_client.py

@@ -40,11 +40,7 @@ def __init__(self, host: str = "host", **kwargs: Any) -> None:
         self._serialize.client_side_validation = False
         self.paging = PagingOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/HeadExceptionsVersionTolerant/headexceptionsversiontolerant/_auto_rest_head_exception_test_service.py

@@ -46,11 +46,7 @@ def __init__(
         self._serialize.client_side_validation = False
         self.head_exception = HeadExceptionOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/HeadVersionTolerant/headversiontolerant/_auto_rest_head_test_service.py

@@ -46,11 +46,7 @@ def __init__(
         self._serialize.client_side_validation = False
         self.http_success = HttpSuccessOperations(self._client, self._config, self._serialize, self._deserialize)
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/LroVersionTolerant/lroversiontolerant/_auto_rest_long_running_operation_test_service.py

@@ -59,11 +59,7 @@ def __init__(
             self._client, self._config, self._serialize, self._deserialize
         )
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest

test/azure/version-tolerant/Expected/AcceptanceTests/LroWithParameterizedEndpointsVersionTolerant/lrowithparameterizedendpointsversiontolerant/_lro_with_paramaterized_endpoints.py

@@ -40,11 +40,7 @@ def __init__(self, host: str = "host", **kwargs: Any) -> None:
         self._deserialize = Deserializer()
         self._serialize.client_side_validation = False
 
-    def send_request(
-        self,
-        request,  # type: HttpRequest
-        **kwargs: Any
-    ) -> HttpResponse:
+    def send_request(self, request: HttpRequest, **kwargs: Any) -> HttpResponse:
         """Runs the network request through the client's chained policies.
 
         >>> from azure.core.rest import HttpRequest