Skip to content
This repository was archived by the owner on Jun 5, 2026. It is now read-only.

Add route for errors with secrets and PII - #354

Merged
heaths merged 9 commits into
Azure:mainfrom
heaths:insecure-error
Mar 1, 2022
Merged

Add route for errors with secrets and PII#354
heaths merged 9 commits into
Azure:mainfrom
heaths:insecure-error

Conversation

@heaths

@heaths heaths commented Feb 25, 2022

Copy link
Copy Markdown
Member

Comment thread src/test-routes/insecure-error.ts Outdated
@heaths

heaths commented Feb 25, 2022

Copy link
Copy Markdown
Member Author

Per @lmazuel added swagger and updated instructions for future devs to do likewise.

@timotheeguerin timotheeguerin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to bump the patch version in packge.json to get it published.

Comment thread .editorconfig Outdated
Comment thread swagger/error-with-secrets.json
@heaths

heaths commented Feb 25, 2022

Copy link
Copy Markdown
Member Author

@timotheeguerin

Will need to bump the patch version in packge.json to get it published.

I did but the rebase dropped it since you had already, apparently. Do we need to do it yet again i.e., is the push automatic from a release pipeline?

@heaths

heaths commented Feb 25, 2022

Copy link
Copy Markdown
Member Author

I want to hold off on actually merging this till I heard back from some of the architects involved in the related archboard issue.

@timotheeguerin

Copy link
Copy Markdown
Member

@timotheeguerin

Will need to bump the patch version in packge.json to get it published.

I did but the rebase dropped it since you had already, apparently. Do we need to do it yet again i.e., is the push automatic from a release pipeline?

Yeah it is a little of a race condition here with the bumping. Before merging you should check that you are up are bumping relative to what is in main otherwise it won't get published.

Resolves feedback for more routes.
Comment thread src/test-routes/error-with-secrets.ts Outdated
@heaths

heaths commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

@bterlson @johanste you good with these endpoints? Keeping up with the constant package.json semver changes is becoming a hassle, so I'd like to get this in ASAP.

@heaths

heaths commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

Because package.json keeps getting updated, I'm merging this now since it's signed off. If someone wants to leave comments I'll take a look and can submit a new PR.

@heaths
heaths enabled auto-merge (squash) March 1, 2022 21:13
@heaths
heaths merged commit fb79023 into Azure:main Mar 1, 2022
@heaths
heaths deleted the insecure-error branch March 1, 2022 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants