created subscription extensions by zikalino · Pull Request #1202 · Azure/azure-cli-extensions

Zim Kalinowski (zikalino) · 2020-01-14T23:54:23Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

Azure Builder (azuresdkci) · 2020-01-14T23:54:44Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Azure/azure-cli-extensions.git@subscriptions-accounts#subdirectory=src/$EXT&egg=$EXT"

Yunge Zhu (yungezz) · 2020-04-20T06:31:53Z

+    examples:
+      - name: Enable subscription
+        text: |-
+               az account subscription enable --subscription-id "7948bcee-488c-47ce-941c-38e20ede803d"


pls use fake subs id

Feng Zhou (fengzhou-msft) · 2020-04-20T07:23:01Z

minCliCoreVersion should also be modified to 2.3.1 to support Experimental tag.

Feng Zhou (fengzhou-msft) · 2020-04-20T07:29:23Z

could be removed.

entire file?

You can keep the file for convenience of future editing.

Feng Zhou (fengzhou-msft) · 2020-04-20T07:30:00Z

3.4, 3.5 could be removed.

Feng Zhou (fengzhou-msft) · 2020-04-20T07:37:50Z

Remove if not used.

Feng Zhou (fengzhou-msft) · 2020-04-20T07:40:14Z

add no_wait=False

Feng Zhou (fengzhou-msft) · 2020-04-20T07:40:25Z

use sdk_no_wait.

Feng Zhou (fengzhou-msft) · 2020-04-20T07:42:35Z

If the action only has one property object_id, we may pass it directly and can get rid of the action.

yeah, that should be deleted, not used

Yong Zhang (yonzhan) · 2020-04-20T08:57:48Z

subscription

Feng Zhou (fengzhou-msft)

LGTM

Zim Kalinowski (zikalino) · 2020-04-20T10:17:19Z

not sure why the test fail in firewall extension now

Yu Chen (jsntcy) self-requested a review January 16, 2020 05:08

Yu Chen (jsntcy) assigned Zim Kalinowski (zikalino) Jan 19, 2020

Yunge Zhu (yungezz) self-assigned this Mar 19, 2020

Yunge Zhu (yungezz) suggested changes Apr 7, 2020

View reviewed changes

Zim Kalinowski (zikalino) requested a review from Yunge Zhu (yungezz) April 14, 2020 17:49

Yunge Zhu (yungezz) approved these changes Apr 20, 2020

View reviewed changes

Yunge Zhu (yungezz) assigned Feng Zhou (fengzhou-msft) Apr 20, 2020

Feng Zhou (fengzhou-msft) reviewed Apr 20, 2020

View reviewed changes

Comment thread src/account/setup.py Outdated

Comment on lines 29 to 30

Feng Zhou (fengzhou-msft) Apr 20, 2020

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.4, 3.5 could be removed.

Feng Zhou (fengzhou-msft) reviewed Apr 20, 2020

View reviewed changes

Comment thread src/account/azext_account/generated/custom.py Outdated

Feng Zhou (fengzhou-msft) Apr 20, 2020

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add no_wait=False

Feng Zhou (fengzhou-msft) reviewed Apr 20, 2020

View reviewed changes

Comment thread src/account/azext_account/generated/custom.py Outdated

Feng Zhou (fengzhou-msft) Apr 20, 2020

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use sdk_no_wait.

Feng Zhou (fengzhou-msft) reviewed Apr 20, 2020

View reviewed changes

Zim Kalinowski (zikalino) requested a review from Zunli Hu (Juliehzl) as a code owner April 20, 2020 09:45

Feng Zhou (fengzhou-msft) approved these changes Apr 20, 2020

View reviewed changes

Zim Kalinowski added 11 commits April 20, 2020 12:22

created subscription extensions

9a40ac5

added sdk

432242f

updated with recent version o autorest.cli

236a953

actions

9c60e6b

actions -> action

a7d3ccb

generated with new version

3cf6857

regenerated

ee2f5c9

fix params

8e5a1ac

moved files into the generated folder

d6d4af3

fix path

d0024f6

fixed more imports

61b7d5d

Zim Kalinowski added 18 commits April 20, 2020 12:23

fix for owner

24d3bcf

fixed body_owners

63d179e

fix

0e040eb

fixes

d976dd1

one more space

63d25e9

more sanity

3e28e39

subscription_id help

3877164

removed pass

55ce4c7

fixed examples

d78d021

fixing examples

a886bd5

example fixes

374ae3a

one more fix

806d0d3

fix to manual part of sdk

cefc20e

fix import

0112cb0

try

b908042

too many blank lines

b9da2b4

fixed help

873cab4

unused import

5ac0ac4

Zim Kalinowski (zikalino) force-pushed the subscriptions-accounts branch from a84a170 to a9ea036 Compare April 20, 2020 10:24

Zim Kalinowski added 8 commits April 20, 2020 12:24

updated example descriptions

23c47b4

confirmation and isexperimental

754b9aa

subscription create

e1f803d

one more

fcb8234

removed isPreview

905b88e

one more blank

795fc55

updated

a9ea036

undo one change

9f78100

Zim Kalinowski (zikalino) changed the title ~~[WIP] created subscription extensions~~ created subscription extensions Apr 20, 2020

Zim Kalinowski (zikalino) merged commit 25e160b into master Apr 20, 2020

Zim Kalinowski (zikalino) deleted the subscriptions-accounts branch April 20, 2020 10:41

Uh oh!

Conversation

Zim Kalinowski (zikalino) commented Jan 14, 2020

General Guidelines

Uh oh!

Azure Builder (azuresdkci) commented Jan 14, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Feng Zhou (fengzhou-msft) Apr 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yong Zhang (yonzhan) commented Apr 20, 2020

Uh oh!

Feng Zhou (fengzhou-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Zim Kalinowski (zikalino) commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Feng Zhou (fengzhou-msft) Apr 20, 2020 •

edited

Loading