[image-copy] Fix copying images created from a blob - #1457
Merged
Conversation
Tamir Kamara (tamirkamara)
marked this pull request as ready for review
March 28, 2020 09:45
Tamir Kamara (tamirkamara)
requested review from
Feng Zhou (fengzhou-msft) and
Harold Ran (haroldrandom)
as code owners
March 28, 2020 09:45
Collaborator
|
add to S168 |
Tamir Kamara (tamirkamara)
force-pushed
the
master
branch
from
April 3, 2020 08:22
2f6e2e9 to
86cdc92
Compare
Feiyue Yu (qwordy)
approved these changes
Apr 3, 2020
Member
|
Please modify setup.py. Remove Python2. |
Contributor
Author
|
I've remove the 2 line of python 2, but now the ci fails but it doesn't really output why. |
Member
|
Log copied from pipeline. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot/create command now requires a storage-account-id parameter when creating snapshots from blob objects. This PR addresses that issue and fixes Azure/azure-cli#12177.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.