Skip to content

[image-copy] Fix copying images created from a blob - #1457

Merged
Feiyue Yu (qwordy) merged 13 commits into
Azure:masterfrom
tamirkamara:master
Apr 17, 2020
Merged

[image-copy] Fix copying images created from a blob#1457
Feiyue Yu (qwordy) merged 13 commits into
Azure:masterfrom
tamirkamara:master

Conversation

@tamirkamara

@tamirkamara Tamir Kamara (tamirkamara) commented Mar 28, 2020

Copy link
Copy Markdown
Contributor

The snapshot/create command now requires a storage-account-id parameter when creating snapshots from blob objects. This PR addresses that issue and fixes Azure/azure-cli#12177.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@tamirkamara Tamir Kamara (tamirkamara) changed the title [image-copy] Fix copying images originally created from a blob [image-copy] Fix copying images created from a blob Mar 28, 2020
@tamirkamara
Tamir Kamara (tamirkamara) marked this pull request as ready for review March 28, 2020 09:45
@yonzhan Yong Zhang (yonzhan) added this to the S168 milestone Mar 28, 2020
@yonzhan

Copy link
Copy Markdown
Collaborator

add to S168

@qwordy

Copy link
Copy Markdown
Member

Please modify setup.py. Remove Python2.
Example:

    'Programming Language :: Python',
    'Programming Language :: Python :: 3',
    'Programming Language :: Python :: 3.6',
    'Programming Language :: Python :: 3.7',
    'Programming Language :: Python :: 3.8',

@tamirkamara

Copy link
Copy Markdown
Contributor Author

I've remove the 2 line of python 2, but now the ci fails but it doesn't really output why.
Can you help Feiyue Yu (@qwordy) ?

@qwordy

Feiyue Yu (qwordy) commented Apr 13, 2020

Copy link
Copy Markdown
Member

Log copied from pipeline.

Results 
=========

-  pass: faulty_help_example_parameters_rule 
-  pass: faulty_help_example_rule 
-  pass: faulty_help_type_rule 
-  pass: unrecognized_help_entry_rule 
-  pass: unrecognized_help_parameter_rule 
-  pass: expired_command_group 
-  pass: missing_group_help 
-  pass: expired_command 
-  pass: missing_command_help 
-  pass: no_ids_for_list_commands 
-  pass: bad_short_option 
-  pass: expired_option 
-  pass: expired_parameter 
-  FAIL: missing_parameter_help
    Parameter: image copy, `tags` - Missing help

@qwordy

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@qwordy
Feiyue Yu (qwordy) merged commit c6506f9 into Azure:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Az image copy extension fails while creating snapshot from Source blob uri

3 participants