[AKS] fix: avoid clearing the autoscaler profile when its not specified - #1527
Merged
Xiaojian Xu (arrownj) merged 1 commit intoApr 13, 2020
Conversation
Marwan Ahmed (marwanad)
requested review from
Ganesha (gtracer) and
Qingqing (zqingqing1)
as code owners
April 12, 2020 05:32
Collaborator
|
add to S168 |
Feiyue Yu (qwordy)
approved these changes
Apr 13, 2020
Xiaojian Xu (arrownj)
self-requested a review
April 13, 2020 05:42
Xiaojian Xu (arrownj)
approved these changes
Apr 13, 2020
Nilay Chheda (mit2nil)
pushed a commit
to mit2nil/azure-cli-extensions
that referenced
this pull request
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.Description for Change:
Before any
aks updatecommand that doesn't specify the autoscaler profile would lead to clearing it becauseif cluster_autoscaler_profileis truthful. This changes that to only clear the profile when an empty string is passed as the autoscaler profile--cluster-autoscaler-profile "", else it would preserve it.