Skip to content

Update spring cloud deployment and app table output to align with Azure portal - #1558

Merged
Myron (mmyyrroonn) merged 1 commit into
Azure:masterfrom
VSChina:yuwzho/spring-cloud-table
Apr 21, 2020
Merged

Update spring cloud deployment and app table output to align with Azure portal#1558
Myron (mmyyrroonn) merged 1 commit into
Azure:masterfrom
VSChina:yuwzho/spring-cloud-table

Conversation

@yuwzho

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Summary

Update table output for command, to align with portal display.
az spring-cloud app list
az spring-cloud app show
az spring-cloud app deployment list
az spring-cloud app deployment show

The new output should be look like
image
and
image

While the portal looks like
image

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

N/A

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Should be shipped with other feature together, no need to update version this time.

@yonzhan

Copy link
Copy Markdown
Collaborator

add to S169

@yungezz Yunge Zhu (yungezz) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/spring-cloud/azext_spring_cloud/_transformers.py
@qwordy

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@yuwzho

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 1558 in repo Azure/azure-cli-extensions

@mmyyrroonn

Copy link
Copy Markdown
Contributor

Yuwei Zhou (@yuwzho) CI has been fixed. 😄

@azuresdkci

Copy link
Copy Markdown

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/VSChina/azure-cli-extensions.git@yuwzho/spring-cloud-table#subdirectory=src/$EXT&egg=$EXT"

@mmyyrroonn
Myron (mmyyrroonn) merged commit 660a5e5 into Azure:master Apr 21, 2020
@yuwzho
Yuwei Zhou (yuwzho) deleted the yuwzho/spring-cloud-table branch May 15, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Spring Cloud Spring Cloud related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants