Skip to content

[SSH] Bug Fix: Using Private IP when --prefer-private-ip is not provided fails #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Mar 11, 2022
Merged

[SSH] Bug Fix: Using Private IP when --prefer-private-ip is not provided fails #4517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ssh/azext_ssh/ip_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def get_ssh_ip(cmd, resource_group, vm_name, use_private_ip):
if public_ip and public_ip.ip_address:
return public_ip.ip_address
if ip_config.private_ip_address:
private_ips += ip_config.private_ip_address
private_ips.append(ip_config.private_ip_address)

if len(private_ips) > 0:
logger.warning("No public IP detected, attempting private IP (you must bring your own connectivity).")
Expand Down